Skip to content

test_pyrepl is taking 1 hour on refleaks buildbots #121988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury opened this issue Jul 18, 2024 · 3 comments
Closed

test_pyrepl is taking 1 hour on refleaks buildbots #121988

colesbury opened this issue Jul 18, 2024 · 3 comments
Labels
tests Tests in the Lib/test dir topic-repl Related to the interactive shell

Comments

@colesbury
Copy link
Contributor

colesbury commented Jul 18, 2024 •
edited by bedevere-app bot
Loading

Looks like it started with ac07451 (cc @AlexWaygood).

https://buildbot.python.org/#/builders/259/builds/1189
https://buildbot.python.org/#/builders/1226/builds/2261

The last time this occurred (#121605) was because:

  1. The refleaks buildbots run with a really long value for SHORT_TIMEOUT
  2. run_repl was hanging until the timeout expired

Linked PRs
@colesbury colesbury added tests Tests in the Lib/test dir topic-repl Related to the interactive shell labels Jul 18, 2024
@colesbury
Copy link
Contributor Author

Oh, probably the same thing with exit vs exit()

cpython/Lib/test/test_pyrepl/test_pyrepl.py

Line 967 in 7dd52b6

] + ["exit"]

colesbury added a commit to colesbury/cpython that referenced this issue Jul 18, 2024
@colesbury
pythongh-121988: Fix test hang (again) when pyrepl is not available
36826d0 
Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
colesbury added a commit to colesbury/cpython that referenced this issue Jul 18, 2024
@colesbury
pythongh-121988: Fix test hang (again) when pyrepl is not available
f7baa36 
Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
colesbury added a commit to colesbury/cpython that referenced this issue Jul 18, 2024
@colesbury
pythongh-121988: Fix test hang when pyrepl is not available
d8b1726 
Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
@bedevere-app bedevere-app bot mentioned this issue Jul 18, 2024
Merged
colesbury added a commit to colesbury/cpython that referenced this issue Jul 19, 2024
@colesbury
Merge branch 'main' into pythongh-121988-repl-exit
c77978d
pablogsal pushed a commit that referenced this issue Jul 20, 2024
@colesbury
gh-121988: Fix test hang when pyrepl is not available (#121990)
a09e215 
Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 20, 2024
@colesbury @miss-islington
pythongh-121988: Fix test hang when pyrepl is not available (pythonGH…
671190f 
…-121990)

Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
(cherry picked from commit a09e215)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Jul 20, 2024
Merged
pablogsal pushed a commit that referenced this issue Jul 20, 2024
@miss-islington @colesbury
[3.13] gh-121988: Fix test hang when pyrepl is not available (GH-121990…
bd5121b 
…) (#122064)

gh-121988: Fix test hang when pyrepl is not available (GH-121990)

Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
(cherry picked from commit a09e215)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@nineteendo
Copy link
Contributor

Is this fully fixed?

@colesbury
Copy link
Contributor Author

Yes, it's fixed now

@encukou encukou mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @nineteendo