Skip to content

Translation strings for auditing events no longer have reST markup #122629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rffontenelle opened this issue Aug 2, 2024 · 1 comment · Fixed by #122651
Closed

Translation strings for auditing events no longer have reST markup #122629

rffontenelle opened this issue Aug 2, 2024 · 1 comment · Fixed by #122651
Assignees
@AA-Turner
Labels
docs Documentation in the Doc dir

Comments

@rffontenelle
Copy link
Contributor

rffontenelle commented Aug 2, 2024 •
edited by AA-Turner
Loading

Documentation

The Python-specific 'audit-event' directive is not being extracted to message catalogs (.po files) with the usual reST markups. For instance, expected a source string as Raises an :ref:`auditing event `sys._getframe <auditing>` with argument ``frame``. but I'm getting Raises an auditing event sys._getframe with argument frame. instead.

#122325 seems to be related to this issue, so cc'ing @AA-Turner .

Steps to reproduce:

  • make -C Doc gettext
  • grep -R 'Raises an auditing event' build/gettext/ for an output like:
build/gettext/library/tempfile.pot:msgid "Raises an auditing event tempfile.mkstemp with argument fullpath."
build/gettext/library/tempfile.pot:msgid "Raises an auditing event tempfile.mkdtemp with argument fullpath."
build/gettext/library/types.pot:msgid "Raises an auditing event function.__new__ with argument code."
build/gettext/library/types.pot:msgid "Raises an auditing event code.__new__ with arguments code, filename, name, argcount, posonlyargcount, kwonlyargcount, nlocals, stacksize, flags."
build/gettext/library/marshal.pot:msgid "Raises an auditing event marshal.dumps with arguments value, version."
build/gettext/library/marshal.pot:msgid "Raises an auditing event marshal.load with no arguments."
build/gettext/library/marshal.pot:msgid "Raises an auditing event marshal.loads with argument bytes."
build/gettext/library/fcntl.pot:msgid "Raises an auditing event fcntl.fcntl with arguments fd, cmd, arg."
build/gettext/library/fcntl.pot:msgid "Raises an auditing event fcntl.ioctl with arguments fd, request, arg."
build/gettext/library/fcntl.pot:msgid "Raises an auditing event fcntl.flock with arguments fd, operation."
build/gettext/library/fcntl.pot:msgid "Raises an auditing event fcntl.lockf with arguments fd, cmd, len, start, whence."
build/gettext/library/functions.pot:msgid "Raises an auditing event builtins.breakpoint with argument breakpointhook."
build/gettext/library/functions.pot:msgid "Raises an auditing event compile with arguments source and filename. This event may also be raised by implicit compilation."
build/gettext/library/functions.pot:msgid "Raises an auditing event exec with the code object as the argument. Code compilation events may also be raised."
build/gettext/library/functions.pot:msgid "Raises an auditing event builtins.id with argument id."
build/gettext/library/functions.pot:msgid "Raises an auditing event builtins.input with argument prompt before reading input"
build/gettext/library/functions.pot:msgid "Raises an auditing event builtins.input/result with the result after successfully reading input."
build/gettext/library/functions.pot:msgid "Raises an auditing event open with arguments path, mode, flags."
...

Linked PRs
@rffontenelle rffontenelle added the docs Documentation in the Doc dir label Aug 2, 2024
@AA-Turner AA-Turner self-assigned this Aug 3, 2024
@AA-Turner
Copy link
Member

Thanks, this is because we no longer set rawsource on a paragraph node we construct. I will open a PR.

A

@AA-Turner AA-Turner mentioned this issue Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AA-Turner AA-Turner

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-121970: Fix gettext for audit events AA-Turner/cpython
2 participants
@rffontenelle @AA-Turner