Skip to content

Document "!" token in lexical analysis document #123579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Glyphack opened this issue Sep 1, 2024 · 3 comments
Closed

Document "!" token in lexical analysis document #123579

Glyphack opened this issue Sep 1, 2024 · 3 comments
Labels
docs Documentation in the Doc dir topic-parser

Comments

@Glyphack
Copy link
Contributor

Glyphack commented Sep 1, 2024 •
edited by bedevere-app bot
Loading

Documentation

I think after PEP701 The ! character became a token.
But this is not listed like other tokens:

It is mentioned in the grammar though: https://docs.python.org/3/reference/lexical_analysis.html#formatted-string-literals

I think it would be helpful to list it in https://docs.python.org/3/reference/lexical_analysis.html or remove the rest of tokens and refer to Grammar/Tokens file so the list is always up to date.

Linked PRs
@Glyphack Glyphack added the docs Documentation in the Doc dir label Sep 1, 2024
@lysnikolaou
Copy link
Member

Thanks for opening an issue @Glyphack! That's a good point. Would you like to submit a PR that adds ! to the list of operators in https://docs.python.org/3/reference/lexical_analysis.html#operators?

@Glyphack
Copy link
Contributor Author

Glyphack commented Sep 2, 2024

Yess I will do thanks for clarifying.

Glyphack added a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@Glyphack
pythongh-123579: Document exclamation token
947e537
Glyphack added a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@Glyphack
pythongh-123579: document exclamation token
d3891ca
@bedevere-app bedevere-app bot mentioned this issue Sep 2, 2024
Merged
Glyphack added a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@Glyphack
pythongh-123579: document exclamation token
c7372e6
lysnikolaou pushed a commit that referenced this issue Sep 3, 2024
@Glyphack
gh-123579: Document exclamation token (#123612)
68fe575
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 3, 2024
@Glyphack @miss-islington
pythongh-123579: Document exclamation token (pythonGH-123612)
8c2f667 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 3, 2024
@Glyphack @miss-islington
pythongh-123579: Document exclamation token (pythonGH-123612)
765ca87 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
This was referenced Sep 3, 2024
Merged
Merged
lysnikolaou pushed a commit that referenced this issue Sep 3, 2024
@miss-islington @Glyphack
[3.12] gh-123579: Document exclamation token (GH-123612) (#123638)
acb19be 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
lysnikolaou pushed a commit that referenced this issue Sep 3, 2024
@miss-islington @Glyphack
[3.13] gh-123579: Document exclamation token (GH-123612) (#123637)
95ebca1 
(cherry picked from commit 68fe575)

Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
@lysnikolaou
Copy link
Member

Fixed in #123612. Thanks @Glyphack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir topic-parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @lysnikolaou @Glyphack