Skip to content

Reference counting stats do not account for immortal objects. #124284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markshannon opened this issue Sep 20, 2024 · 1 comment
Closed

Reference counting stats do not account for immortal objects. #124284

markshannon opened this issue Sep 20, 2024 · 1 comment
Assignees
@markshannon
Labels
pending The issue will be closed if no feedback is provided

Comments

@markshannon
Copy link
Member

markshannon commented Sep 20, 2024 •
edited by bedevere-app bot
Loading

Bug description:

The reference counting stats (for example) show stats for increfs and decrefs (both in the interpreter and in the rest of the executable).

One might assume that is the number of Py_INCREF and Py_DECREFs executed, but it is not. It is the number of Py_INCREF and Py_DECREF where the object in question is mortal. We should add stats for Py_INCREF and Py_DECREFs of immortal objects as well.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@markshannon markshannon self-assigned this Sep 20, 2024
@bedevere-app bedevere-app bot mentioned this issue Sep 20, 2024
Merged
markshannon added a commit that referenced this issue Sep 23, 2024
@markshannon
GH-124284: Add stats for refcount operations on immortal objects (GH-…
c87b0e4 
…124288)
@vstinner
Copy link
Member

@markshannon: I suppose that this issue can now be closed since the change c87b0e4 was merged.

@vstinner vstinner added the pending The issue will be closed if no feedback is provided label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markshannon markshannon

Labels
pending The issue will be closed if no feedback is provided
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @markshannon