Skip to content

GH-124284: Add stats for refcount operations on immortal objects #124288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2024
Merged

GH-124284: Add stats for refcount operations on immortal objects #124288

merged 4 commits into from
Sep 23, 2024
+45 −10

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Sep 20, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 20, 2024
Closed
Fidget-Spinner
Fidget-Spinner approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If there's any subtle bugs we can fix them later. It's stats anyways not something mission critical.

@markshannon
Copy link
Member Author

Heres' what the stats look like: https://github.com/faster-cpython/benchmarking-public/blob/main/results/bm-20240920-3.14.0a0-e179c31/bm-20240920-azure-x86_64-faster%252dcpython-immortal_ref_count_s-3.14.0a0-e179c31-pystats.md#object-stats

@markshannon markshannon merged commit c87b0e4 into python:main Sep 23, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @Fidget-Spinner