-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Update turtledemo docstrings with correct file names #125665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…python#125691) Co-authored-by: Wulian <xiguawulian@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Can I ask why have the filename in the docstring at all? That’s not the recommended format for docstrings, and if it’s needed by the demo machinery or the tests, then it can be found from the file without having to be in the docstring. |
The original author put them there and I did not consider removing them completely, as opposed to correcting and condensing the previous headers. When files are printed (less common now than it used to be), it is nice to have the filename printed. Since this might be more useful in classrooms where turtledemo is used than in professional settings, I am not inclinded to remove them. |
Bug report
Bug description:
In #123370 , I discussed with Terry some measures to modernize the turtledemo. This requires changes to each file. First, I want to modify the incorrect comment file names, which is the easiest to review. There are five measures to modify, e.g German function names and parameter names, change ISO format time, and others focus on clock.py. I have already completed 2 in my initial commit in a0b922f , but I later reverted the changes due to backporting
From previous discussion:
(clock.py fixed)
This issue is a bug fix, not a modernization enhancement?
Linked PRs
The text was updated successfully, but these errors were encountered: