Skip to content

Remove DeprecationWarnings in test_peg_generator #125811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efimov-mikhail opened this issue Oct 21, 2024 · 0 comments
Closed

Remove DeprecationWarnings in test_peg_generator #125811

efimov-mikhail opened this issue Oct 21, 2024 · 0 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@efimov-mikhail
Copy link
Contributor

efimov-mikhail commented Oct 21, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

Some DeprecationWarnings are present in test.test_peg_generator.test_pegen output:

-> % (make -j && ./python -m unittest -v test.test_peg_generator.test_pegen) 2>&1 | grep Deprecation
test_locations_in_alt_action_and_group (test.test_peg_generator.test_pegen.TestPegen.test_locations_in_alt_action_and_group) ... <string>:29: DeprecationWarning: Expression.__init__ got an unexpected keyword argument 'lineno'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.
<string>:29: DeprecationWarning: Expression.__init__ got an unexpected keyword argument 'col_offset'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.
<string>:29: DeprecationWarning: Expression.__init__ got an unexpected keyword argument 'end_lineno'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.
<string>:29: DeprecationWarning: Expression.__init__ got an unexpected keyword argument 'end_col_offset'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.
test_python_expr (test.test_peg_generator.test_pegen.TestPegen.test_python_expr) ... <string>:25: DeprecationWarning: Expression.__init__ got an unexpected keyword argument 'lineno'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.
<string>:25: DeprecationWarning: Expression.__init__ got an unexpected keyword argument 'col_offset'. Support for arbitrary keyword arguments is deprecated and will be removed in Python 3.15.

Those warning can be easily removed.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
@efimov-mikhail efimov-mikhail added the type-feature A feature request or enhancement label Oct 21, 2024
@Eclips4 Eclips4 added the tests Tests in the Lib/test dir label Oct 21, 2024
efimov-mikhail added a commit to efimov-mikhail/cpython that referenced this issue Oct 21, 2024
@efimov-mikhail
pythongh-125811: Remove DeprecationWarnings in test_peg_generator
75df207
@bedevere-app bedevere-app bot mentioned this issue Oct 21, 2024
Merged
pablogsal pushed a commit that referenced this issue Oct 22, 2024
@efimov-mikhail
gh-125811: Remove DeprecationWarnings in test_peg_generator (#125812)
4efe64a
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 22, 2024
@efimov-mikhail @miss-islington
pythongh-125811: Remove DeprecationWarnings in test_peg_generator (py…
6b93b73 
…thonGH-125812)

(cherry picked from commit 4efe64a)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Oct 22, 2024
Merged
pablogsal pushed a commit that referenced this issue Oct 22, 2024
@miss-islington @efimov-mikhail
[3.13] gh-125811: Remove DeprecationWarnings in test_peg_generator (G…
e3bfe1e 
…H-125812) (#125831)

gh-125811: Remove DeprecationWarnings in test_peg_generator (GH-125812)
(cherry picked from commit 4efe64a)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@efimov-mikhail @ebonnal
pythongh-125811: Remove DeprecationWarnings in test_peg_generator (py…
0fee979 
…thon#125812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@efimov-mikhail @lysnikolaou @Eclips4