Skip to content

Outdated post PEP-709 comment in Python/codegen.c #125832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eclips4 opened this issue Oct 22, 2024 · 5 comments
Closed

Outdated post PEP-709 comment in Python/codegen.c #125832

Eclips4 opened this issue Oct 22, 2024 · 5 comments
Assignees
@rimi0108
Labels
easy interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@Eclips4
Copy link
Member

Eclips4 commented Oct 22, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

After the implementation of https://peps.python.org/pep-0709/, this comment looks wrong:

cpython/Python/codegen.c

Lines 4079 to 4090 in 57e3c59

/* List and set comprehensions and generator expressions work by creating a
nested function to perform the actual iteration. This means that the
iteration variables don't leak into the current scope.
The defined function is called immediately following its definition, with the
result of that call being the result of the expression.
The LC/SC version returns the populated container, while the GE version is
flagged in symtable.c as a generator, so it returns the generator object
when the function is called.
Possible cleanups:
- iterate over the generator sequence instead of using recursion
*/

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@Eclips4 Eclips4 added type-bug An unexpected behavior, bug, or error easy labels Oct 22, 2024
@picnixz
Copy link
Member

picnixz commented Oct 22, 2024

Haven't checked in the code yet but generator expressions do not seem to be concerned by the inlining:

Generator expressions are currently not inlined in the reference implementation of this PEP. In the future, some generator expressions may be inlined, where the returned generator object does not leak.

@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Oct 22, 2024
@rimi0108
Copy link
Contributor

rimi0108 commented Nov 2, 2024

I will take a look :)

@corona10
Copy link
Member

corona10 commented Nov 2, 2024 •
edited
Loading

@willingc

@rimi0108 is going to take a look at this issue during the KR sprint too :)

@bedevere-app bedevere-app bot mentioned this issue Nov 2, 2024
Merged
@picnixz picnixz changed the title Outdated comment in Python/codegen.c Outdated post PEP-709 comment in Python/codegen.c Nov 2, 2024
willingc added a commit that referenced this issue Nov 2, 2024
@rimi0108 @willingc @rruuaanng
gh-125832: Clarify comment for inlined comprehensions as per PEP-709 (#…
868bfcc 
…126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
@corona10
Copy link
Member

corona10 commented Nov 3, 2024

Thanks for the contribution! @rimi0108

@corona10 corona10 closed this as completed Nov 3, 2024
@corona10 corona10 reopened this Nov 3, 2024
@corona10
Copy link
Member

corona10 commented Nov 3, 2024

We need to handle backport patch as well.

@bedevere-app bedevere-app bot mentioned this issue Nov 3, 2024
Merged
corona10 pushed a commit to corona10/cpython that referenced this issue Nov 3, 2024
@rimi0108 @willingc
@rruuaanng @corona10
pythongh-125832: Clarify comment for inlined comprehensions as per PE…
62ddc5f 
…P-709 (python#126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
(cherry picked from commit 868bfcc)
corona10 pushed a commit to corona10/cpython that referenced this issue Nov 3, 2024
@rimi0108 @willingc
@rruuaanng @corona10
[3.12] pythongh-125832: Clarify comment for inlined comprehensions as…
c7a3bbe 
… per PEP-709 (pythongh-126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 3, 2024
Merged
corona10 added a commit to corona10/cpython that referenced this issue Nov 3, 2024
@corona10
pythongh-125832: Reformat comments for inlined comprehensions
252aaa9
@bedevere-app bedevere-app bot mentioned this issue Nov 3, 2024
Merged
corona10 added a commit that referenced this issue Nov 3, 2024
@corona10 @rimi0108
@willingc @rruuaanng
[3.12] gh-125832: Clarify comment for inlined comprehensions as per P… (
4afa129 
gh-126345)

* [3.12] gh-125832: Clarify comment for inlined comprehensions as per PEP-709 (gh-126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add space

---------

Co-authored-by: rimchoi <hyerimc858@gmail.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
corona10 added a commit that referenced this issue Nov 3, 2024
@corona10 @rimi0108
[3.13] gh-125832: Clarify comment for inlined comprehensions as per P…
36079f7 
…EP-709 (gh-126322) (gh-126344)

* gh-125832: Clarify comment for inlined comprehensions as per PEP-709 (#126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
(cherry picked from commit 868bfcc)

* Add space

---------

Co-authored-by: rimchoi <hyerimc858@gmail.com>
corona10 added a commit that referenced this issue Nov 3, 2024
@corona10
gh-125832: Reformat comments for inlined comprehensions (gh-126346)
8161afe
@corona10 corona10 closed this as completed Nov 3, 2024
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@rimi0108 @willingc
@rruuaanng @picnixz
pythongh-125832: Clarify comment for inlined comprehensions as per PE…
e195285 
…P-709 (python#126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@corona10 @picnixz
pythongh-125832: Reformat comments for inlined comprehensions (python…
e942e7c 
…gh-126346)
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@rimi0108 @willingc
@rruuaanng @ebonnal
pythongh-125832: Clarify comment for inlined comprehensions as per PE…
d073284 
…P-709 (python#126322)

* Fix comprehensions comment to inlined by pep 709

* Update spacing

Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>

* Add reference to PEP 709

---------

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: RUANG (James Roy) <longjinyii@outlook.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@corona10 @ebonnal
pythongh-125832: Reformat comments for inlined comprehensions (python…
2d8b007 
…gh-126346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimi0108 rimi0108

Labels
easy interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@corona10 @picnixz @rimi0108 @Eclips4