Skip to content

Add ARIA labels to improve documentation accessibility #125933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Privat33r-dev opened this issue Oct 24, 2024 · 0 comments · Fixed by #125934
Closed

Add ARIA labels to improve documentation accessibility #125933

Privat33r-dev opened this issue Oct 24, 2024 · 0 comments · Fixed by #125934
Labels
docs Documentation in the Doc dir

Comments

@Privat33r-dev
Copy link
Contributor

Privat33r-dev commented Oct 24, 2024 •
edited by bedevere-app bot
Loading

Documentation

According to the Lighthouse report, select elements do not have labels.
image

These select elements are rendered in the JS in Doc/tools/static/rtd_switcher.js.

The issue was originally outlined on the Discourse (6th point).

Linked PRs
@Privat33r-dev Privat33r-dev added the docs Documentation in the Doc dir label Oct 24, 2024
@Privat33r-dev Privat33r-dev mentioned this issue Oct 24, 2024
Merged
@hugovk hugovk changed the title Add labels to improve documentation accessibility Add ARIA labels to improve documentation accessibility Oct 24, 2024
hugovk added a commit that referenced this issue Oct 24, 2024
@Privat33r-dev @hugovk
gh-125933: Add ARIA labels to select elements in the version switcher (…
1306f33 
…#125934)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 24, 2024
@Privat33r-dev @hugovk @miss-islington
pythongh-125933: Add ARIA labels to select elements in the version sw…
6d7c090 
…itcher (pythonGH-125934)

(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 24, 2024
@Privat33r-dev @hugovk @miss-islington
pythongh-125933: Add ARIA labels to select elements in the version sw…
9afc087 
…itcher (pythonGH-125934)

(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This was referenced Oct 24, 2024
Merged
Merged
hugovk added a commit that referenced this issue Oct 24, 2024
@miss-islington @Privat33r-dev @hugovk
[3.13] gh-125933: Add ARIA labels to select elements in the version s…
92d301e 
…witcher (GH-125934) (#125938)

gh-125933: Add ARIA labels to select elements in the version switcher (GH-125934)
(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this issue Oct 24, 2024
@miss-islington @Privat33r-dev @hugovk
[3.12] gh-125933: Add ARIA labels to select elements in the version s…
31ff9e5 
…witcher (GH-125934) (#125939)

gh-125933: Add ARIA labels to select elements in the version switcher (GH-125934)
(cherry picked from commit 1306f33)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@Privat33r-dev @hugovk @ebonnal
pythongh-125933: Add ARIA labels to select elements in the version sw…
0f7b22e 
…itcher (python#125934)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-125933: Add ARIA labels to select elements in the version switcher Privat33r-dev/cpython
1 participant
@Privat33r-dev