Skip to content

socket.send_fds() flags and address parameters have no effect #127840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mbachry opened this issue Dec 11, 2024 · 1 comment
Open

socket.send_fds() flags and address parameters have no effect #127840

mbachry opened this issue Dec 11, 2024 · 1 comment
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@mbachry
Copy link
Contributor

mbachry commented Dec 11, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

socket.send_fds accepts flags and address parameters, but they aren't passed down to socket.sendmsg.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs
@mbachry mbachry added the type-bug An unexpected behavior, bug, or error label Dec 11, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 11, 2024
Merged
@picnixz picnixz added the stdlib Python modules in the Lib dir label Dec 13, 2024
gpshead pushed a commit that referenced this issue May 22, 2025
@mbachry @ZeroIntensity
gh-127840: pass flags and address from send_fds (GH-127841)
518c95b 
socket: pass flags and address from send_fds

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025
@mbachry @ZeroIntensity @miss-islington
pythongh-127840: pass flags and address from send_fds (pythonGH-127841)
82410b6 
socket: pass flags and address from send_fds
(cherry picked from commit 518c95b)

Co-authored-by: Marcin Bachry <hegel666@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025
@mbachry @ZeroIntensity @miss-islington
pythongh-127840: pass flags and address from send_fds (pythonGH-127841)
4e4a64b 
socket: pass flags and address from send_fds
(cherry picked from commit 518c95b)

Co-authored-by: Marcin Bachry <hegel666@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This was referenced May 22, 2025
Closed
Closed
gpshead added a commit to gpshead/cpython that referenced this issue May 22, 2025
@gpshead
Revert "pythongh-127840: pass flags and address from send_fds (python…
bca6c17 
…GH-127841)"

This reverts commit 518c95b.
@bedevere-app bedevere-app bot mentioned this issue May 22, 2025
Merged
gpshead added a commit that referenced this issue May 22, 2025
@gpshead
gh-127840: Revert "gh-127840: pass flags and address from send_fds (G…
296a660 
…H-127841)" (#134482)

Revert "gh-127840: pass flags and address from send_fds (GH-127841)"

This reverts commit 518c95b.
@gpshead
Copy link
Member

gpshead commented May 22, 2025

the original PR was reverted due to an issue on the cpython test suite side. it had passed our CI many months ago. i didn't hit Update on it before finally merging; if I had, it'd have failed as the buildbots and backport PRs such as #134474 did. easy to fix as noted in #127841 (comment)

lkollar pushed a commit to lkollar/cpython that referenced this issue May 26, 2025
@mbachry @ZeroIntensity @lkollar
pythongh-127840: pass flags and address from send_fds (pythonGH-127841)
1b17f79 
socket: pass flags and address from send_fds

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this issue May 26, 2025
@gpshead @lkollar
pythongh-127840: Revert "pythongh-127840: pass flags and address from…
915e124 
… send_fds (pythonGH-127841)" (python#134482)

Revert "pythongh-127840: pass flags and address from send_fds (pythonGH-127841)"

This reverts commit 518c95b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gpshead @mbachry @picnixz