Skip to content

Fix the font size and shortcut display of the turtledemo menu #128062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xiaokang2022 opened this issue Dec 18, 2024 · 2 comments
Closed

Fix the font size and shortcut display of the turtledemo menu #128062

Xiaokang2022 opened this issue Dec 18, 2024 · 2 comments
Assignees
Labels
type-bug An unexpected behavior, bug, or error

Comments

@Xiaokang2022
Copy link
Contributor

Xiaokang2022 commented Dec 18, 2024

Bug description:

The font size of turtledemo's menu bar is too large and the shortcut keys are not displayed well enough.

Actually:

2024-12-18-18-07-39

But better: (Changed the font and the way shortcuts are displayed)

2024-12-18-18-05-29

I'll create a PR later to fix it.

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs

@Xiaokang2022 Xiaokang2022 added the type-bug An unexpected behavior, bug, or error label Dec 18, 2024
@terryjreedy terryjreedy self-assigned this Dec 18, 2024
@terryjreedy terryjreedy changed the title The font size of turtledemo's menu bar is too large and the shortcut keys are not displayed well enough Fix the font size and shortcut display of the turtledemo menu Dec 18, 2024
@terryjreedy
Copy link
Member

On my MacBook Air, with a small screen, fontsize 12 is too small as the default, used for the top bar, appears to be 14. Command+- and Command+= are the keys that work in the text widget. Agree with leaving size alone and using the standard accelerator option.

terryjreedy added a commit that referenced this issue Dec 19, 2024
…enu (#128063)

Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.
---------

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 19, 2024
…demo menu (pythonGH-128063)

Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.
---------

(cherry picked from commit e163e8d)

Co-authored-by: Zhikang Yan <2951256653@qq.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this issue Dec 19, 2024
…edemo menu (GH-128063) (#128101)

gh-128062: Fix the font size and shortcut display of the turtledemo menu (GH-128063)

Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.
---------

(cherry picked from commit e163e8d)

Co-authored-by: Zhikang Yan <2951256653@qq.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy
Copy link
Member

The 3.12 backport failed with a merge conflict. I consider it low priority.

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Dec 23, 2024
…demo menu (python#128063)

Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.
---------

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
…demo menu (python#128063)

Leave the font of the menu bar the default to keep it consistent with the rest of the world. Display the shortcut keys in the right way, using the 'accelerator' option.
---------

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
Development

No branches or pull requests

2 participants