Skip to content

3.14 build error after recent commit: pylifecycle.c:50:12: fatal error: os/log.h: No such file or directory #128146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
barracuda156 opened this issue Dec 21, 2024 · 5 comments
Closed

3.14 build error after recent commit: pylifecycle.c:50:12: fatal error: os/log.h: No such file or directory #128146

barracuda156 opened this issue Dec 21, 2024 · 5 comments
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error

Comments

@barracuda156
Copy link

barracuda156 commented Dec 21, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The recent commit 2041a95 has broken the build of Python for a number of macOS versions, since <os/log.h> is not guaranteed to exist, but has been included unconditionally.

Python/pylifecycle.c:50:12: fatal error: os/log.h: No such file or directory
   50 | #  include <os/log.h>
      |            ^~~~~~~~~~
compilation terminated.
make: *** [Python/pylifecycle.o] Error 1
make: *** Waiting for unfinished jobs....

@freakboy3742 Could you please take a look at this?

CPython versions tested on:

3.14

Operating systems tested on:

macOS

Linked PRs
@barracuda156 barracuda156 added the type-bug An unexpected behavior, bug, or error label Dec 21, 2024
barracuda156 referenced this issue Dec 21, 2024
@freakboy3742
gh-126925: Modify how iOS test results are gathered (#127592)
2041a95 
Adds a `use_system_log` config item to enable stdout/stderr redirection for
Apple platforms. This log streaming is then used by a new iOS test runner
script, allowing the display of test suite output at runtime. The iOS test
runner script can be used by any Python project, not just the CPython test
suite.
@freakboy3742
Copy link
Contributor

@barracuda156 When you say "A number of macOS versions" - can you clarify which ones you mean? I'm guessing the availability issue is the one referred to by this comment; in which case, the fix is likely using the same #ifdef gate on the os/log.h import.

@barracuda156
Copy link
Author

@freakboy3742 Yes, I believe, that is correct: https://groups.google.com/a/chromium.org/g/crashpad-dev/c/5CY_M9R6mIw

@picnixz picnixz added OS-mac build The build process and cross-build 3.13 bugs and security fixes 3.14 bugs and security fixes labels Dec 21, 2024
@bedevere-app bedevere-app bot mentioned this issue Dec 22, 2024
Merged
@freakboy3742
Copy link
Contributor

@barracuda156 Presumptive fix in #128165; it's currently failing CI for reasons that I can't explain, and I can't reproduce locally.

@barracuda156
Copy link
Author

@freakboy3742 Thank you, I will run the build and let you know.

freakboy3742 added a commit that referenced this issue Jan 7, 2025
@freakboy3742
gh-128146: Exclude os/log.h import on older macOS versions. (#128165)
e837a1f 
Reworks the handling of Apple system log handling to account for older macOS 
versions that don't provide os-log.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 7, 2025
@freakboy3742 @miss-islington
pythongh-128146: Exclude os/log.h import on older macOS versions. (py…
6413f7b 
…thonGH-128165)

Reworks the handling of Apple system log handling to account for older macOS
versions that don't provide os-log.
(cherry picked from commit e837a1f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app bedevere-app bot mentioned this issue Jan 7, 2025
Merged
freakboy3742 added a commit that referenced this issue Jan 7, 2025
@miss-islington @freakboy3742
[3.13] gh-128146: Exclude os/log.h import on older macOS versions. (G…
bbe0b33 
…H-128165) (#128575)

gh-128146: Exclude os/log.h import on older macOS versions. (GH-128165)

Reworks the handling of Apple system log handling to account for older macOS
versions that don't provide os-log.
(cherry picked from commit e837a1f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 8, 2025
@freakboy3742 @srinivasreddy
pythongh-128146: Exclude os/log.h import on older macOS versions. (py…
81a5694 
…thon#128165)

Reworks the handling of Apple system log handling to account for older macOS 
versions that don't provide os-log.
@hugovk
Copy link
Member

hugovk commented Jan 8, 2025

PR merged and backported, thanks all!

@hugovk hugovk closed this as completed Jan 8, 2025
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Mar 16, 2025
@miss-islington @freakboy3742
[3.11] pythongh-128146: Exclude os/log.h import on older macOS versio…
0298df1 
…ns. (pythonGH-128165) (python#128575)

pythongh-128146: Exclude os/log.h import on older macOS versions. (pythonGH-128165)

Reworks the handling of Apple system log handling to account for older macOS
versions that don't provide os-log.
(cherry picked from commit e837a1f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Mar 16, 2025
@miss-islington @freakboy3742
[3.10] pythongh-128146: Exclude os/log.h import on older macOS versio…
ae6d05e 
…ns. (pythonGH-128165) (python#128575)

pythongh-128146: Exclude os/log.h import on older macOS versions. (pythonGH-128165)

Reworks the handling of Apple system log handling to account for older macOS
versions that don't provide os-log.
(cherry picked from commit e837a1f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Mar 16, 2025
@miss-islington @freakboy3742
[3.9] pythongh-128146: Exclude os/log.h import on older macOS version…
638150f 
…s. (pythonGH-128165) (python#128575)

pythongh-128146: Exclude os/log.h import on older macOS versions. (pythonGH-128165)

Reworks the handling of Apple system log handling to account for older macOS
versions that don't provide os-log.
(cherry picked from commit e837a1f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes build The build process and cross-build OS-mac type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@freakboy3742 @hugovk @picnixz @barracuda156