Skip to content

_MIPS_SIM comparison may contain undefined identifiers for _ABI #132026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sigv opened this issue Apr 2, 2025 · 2 comments
Closed

_MIPS_SIM comparison may contain undefined identifiers for _ABI #132026

sigv opened this issue Apr 2, 2025 · 2 comments
Labels
build The build process and cross-build OS-unsupported type-bug An unexpected behavior, bug, or error

Comments

@sigv
Copy link
Contributor

sigv commented Apr 2, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

#include <Python.h>

When built on a MIPS architecture, _MIPS_SIM is used to determine architecture specifics. The value is expected to match either _ABIO32, _ABIN32 or _ABI64.

In gcc config/mips/mips.h these values are defined as compiler builtin_define inside of a switch/case. That means, mips64el and mips64 architectures know about _ABI64 but don't know about _ABIO32 and _ABIN32. In turn, when CPython tries to use them in comparison, they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be evaluated as zero, and it will not match _MIPS_SIM. However, the issues pop up when -Wundef (or, even worse, -Werror=undef) compiler flag is enabled. Then suddenly it's visible as a warning or error:

In file included from /usr/include/python3.13/Python.h:14,
                 from example.c:1:
/usr/include/python3.13/pyconfig.h:59:20: error: "_ABIO32" is not defined, evaluates to 0 [-Werror=undef]
   59 | #  if _MIPS_SIM == _ABIO32
      |                    ^~~~~~~
/usr/include/python3.13/pyconfig.h:61:22: error: "_ABIN32" is not defined, evaluates to 0 [-Werror=undef]
   61 | #  elif _MIPS_SIM == _ABIN32
      |                      ^~~~~~~

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs
@sigv sigv added the type-bug An unexpected behavior, bug, or error label Apr 2, 2025
sigv added a commit to sigv/cpython that referenced this issue Apr 2, 2025
@sigv
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
7492f2b 
…mparison

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
@bedevere-app bedevere-app bot mentioned this issue Apr 2, 2025
Merged
sigv added a commit to sigv/cpython that referenced this issue Apr 2, 2025
@sigv
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
d76f84e 
…mparison

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
@tomasr8 tomasr8 added the build The build process and cross-build label Apr 4, 2025
@picnixz picnixz added interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-unsupported and removed interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 4, 2025
sigv added a commit to sigv/cpython that referenced this issue Apr 6, 2025
@sigv
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
5dea448 
…mparison

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
sigv added a commit to sigv/cpython that referenced this issue Apr 6, 2025
@sigv
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
f37099c 
…mparison

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
@sigv
Copy link
Contributor Author

sigv commented Apr 6, 2025

This should be added to Platform: MIPS on Unsupported platforms board.

sigv added a commit to sigv/cpython that referenced this issue Apr 6, 2025
@sigv
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
da82bea 
…mparison

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
sigv added a commit to sigv/cpython that referenced this issue Apr 14, 2025
@sigv
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
af87dfe 
…mparison

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
zware pushed a commit that referenced this issue Apr 27, 2025
@sigv
gh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for comparis…
6985e2e 
…on (GH-132027)

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 28, 2025
@sigv @miss-islington
pythongh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for co…
7735662 
…mparison (pythonGH-132027)

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
(cherry picked from commit 6985e2e)

Co-authored-by: Valters Jansons <sigv@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Apr 28, 2025
Merged
zware pushed a commit that referenced this issue Apr 28, 2025
@miss-islington @sigv
[3.13] gh-132026: Ensure _MIPS_SIM has defined _ABI identifiers for c…
507b4fa 
…omparison (GH-133092)

When built on a MIPS architecture, `_MIPS_SIM` is used to determine
architecture specifics. The value is expected to match either
`_ABIO32`, `_ABIN32` or `_ABI64`.

In `gcc` config/mips/mips.h these values are defined as compiler
`builtin_define` inside of a switch/case. That means, mips64el and
mips64 architectures know about `_ABI64` but don't know about `_ABIO32`
and `_ABIN32`. In turn, when CPython tries to use them in comparison,
they may be undefined identifiers.

In default compiler behavior, the undefined identifier will be
evaluated as zero, and it will not match `_MIPS_SIM`. However, the
issues pop up when `-Wundef` (or, even worse, `-Werror=undef`) compiler
flag is enabled. Then suddenly it's visible as a warning or error.
(cherry picked from commit 6985e2e)

Co-authored-by: Valters Jansons <sigv@users.noreply.github.com>
@zware
Copy link
Member

zware commented Apr 28, 2025

Merged and backported; thanks for the report and patch!

@zware zware closed this as completed Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-unsupported type-bug An unexpected behavior, bug, or error
Projects
Unsupported platforms
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sigv @zware @tomasr8 @picnixz