Skip to content

Commit with _PyCode_GetVarCounts() broke buildbots #133224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sobolevn opened this issue Apr 30, 2025 · 1 comment
Closed

Commit with _PyCode_GetVarCounts() broke buildbots #133224

sobolevn opened this issue Apr 30, 2025 · 1 comment
Labels
3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 30, 2025

Example: https://buildbot.python.org/#/builders/1636/builds/305/steps/6/logs/stdio

  test_var_counts (test.test_code.CodeTest.test_var_counts) ... Fatal Python error: Segmentation fault

Current thread 0x000003ffb3d77740 [python] (most recent call first):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/test_code.py", line 974 in test_var_counts
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/case.py", line 615 in _callTestMethod
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/case.py", line 669 in run
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/case.py", line 725 in __call__
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/unittest/runner.py", line 259 in run
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 84 in _run_suite
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 42 in run_unittest
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 162 in test_func
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 118 in regrtest_runner
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 165 in _load_run_test
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 210 in _runtest_env_changed_exc
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 319 in _runtest
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/single.py", line 348 in run_single_test
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/worker.py", line 92 in worker_process
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/worker.py", line 127 in main
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/test/libregrtest/worker.py", line 131 in <module>
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/runpy.py", line 88 in _run_code
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/Lib/runpy.py", line 198 in _run_module_as_main

Current thread's C stack trace (most recent call first):
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at _Py_DumpStack+0x2e [0x12be1e6]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x12d237e]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x12d2698]
  Binary file "linux-vdso64.so.1", at __kernel_sigreturn+0x0 [0x3ffdc4fe4d8]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x127e454]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10bb114]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at _PyCode_SetUnboundVarCounts+0xbe [0x10be136]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/build/lib.linux-s390x-3.14/_testinternalcapi.cpython-314d-s390x-linux-gnu.so", at +0x9826 [0x3ffa5109826]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1113148]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at _PyObject_MakeTpCall+0xb4 [0x10b4a1c]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b4c44]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at PyObject_Vectorcall+0x42 [0x10b4cda]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at _PyEval_EvalFrameDefault+0x4862 [0x1202372]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1222c84]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1222e96]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b4876]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b7d18]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b7e86]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b60aa]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b639a]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at PyObject_Call+0x3e [0x10b63f6]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at _PyEval_EvalFrameDefault+0x763a [0x120514a]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1222c84]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1222e96]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b4876]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b5dba]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b5fb6]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1159664]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x1159768]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at _PyObject_MakeTpCall+0xb4 [0x10b4a1c]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python" [0x10b4c44]
  Binary file "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x/build/python", at PyObject_Vectorcall+0x42 [0x10b4cda]
  <truncated rest of calls>

Extension modules: _testinternalcapi, _testcapi (total: 2)

Refs #133128
CC @ericsnowcurrently

@sobolevn sobolevn added the type-crash A hard crash of the interpreter, possibly with a core dump label Apr 30, 2025
@tomasr8 tomasr8 added interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.14 new features, bugs and security fixes labels Apr 30, 2025
@ericsnowcurrently
Copy link
Member

I'm reverting that change for now: gh-133232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Development

No branches or pull requests

3 participants