Skip to content

Reorganize WASI-related files in Tools/wasm #133600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettcannon opened this issue May 7, 2025 · 7 comments
Closed

Reorganize WASI-related files in Tools/wasm #133600

brettcannon opened this issue May 7, 2025 · 7 comments
Assignees
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes OS-wasi

Comments

@brettcannon
Copy link
Member

brettcannon commented May 7, 2025

The files in Tools/wasm are a little messy as nearly all Emscripten-related files are in emscripten/ while the WASI-related files are not. So I want to:

  • Add a wasi/ directory and move code related to wasi.py there
  • Make wasi.py a deprecated shim for calling wasi/
  • Update CODEOWNERS such that @freakboy3742 isn't bothered about WASI-only stuff and I'm not bothered about Emscripten-only stuff
@brettcannon brettcannon self-assigned this May 7, 2025
@brettcannon brettcannon added OS-wasi 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels May 7, 2025
@brettcannon
Copy link
Member Author

I have a PR ready to go into main and then to backport to 3.14, but main is currently broken for cross-builds (should be fixed by #133599).

brettcannon added a commit that referenced this issue May 7, 2025
Along the way, also move related files into their appropriate directories and update `.github/CODEOWNERS`.
brettcannon added a commit to brettcannon/cpython that referenced this issue May 7, 2025
@brettcannon
Copy link
Member Author

ee49644 was an accidental preview of the PR. 😅

@brettcannon
Copy link
Member Author

@freakboy3742 the decision was made on Discord that it was better to just leave my mistake commit, so in classic EAFP tradition I'm asking if you have any feedback on the changes I made and anything you want me to change.

@freakboy3742
Copy link
Contributor

@brettcannon I think that all makes sense to me.

The only bigger picture question I've got is around the use of the Tools directory - I appreciate there's history and backwards compatibility issues, but if we're doing a re-org anyway, does it make any sense to promote wasm to a top-level folder in the repo, similar to every other supported platform?

@brettcannon
Copy link
Member Author

if we're doing a re-org anyway, does it make any sense to promote wasm to a top-level folder in the repo, similar to every other supported platform?

Possibly. I think that's a bigger question for the overall core team (something you want to bring up at the language summit?).

@brettcannon
Copy link
Member Author

BTW I left the config.site file in place for Emscripten as I wasn't sure if you wanted to move it into the emscripten/ directory or not.

@freakboy3742
Copy link
Contributor

if we're doing a re-org anyway, does it make any sense to promote wasm to a top-level folder in the repo, similar to every other supported platform?

Possibly. I think that's a bigger question for the overall core team (something you want to bring up at the language summit?).

I already have a slide for this (in the context of support for other Apple platforms). 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes OS-wasi
Projects
None yet
Development

No branches or pull requests

2 participants