-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Reorganize WASI-related files in Tools/wasm
#133600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I have a PR ready to go into |
Along the way, also move related files into their appropriate directories and update `.github/CODEOWNERS`.
This reverts commit ee49644.
ee49644 was an accidental preview of the PR. 😅 |
@freakboy3742 the decision was made on Discord that it was better to just leave my mistake commit, so in classic EAFP tradition I'm asking if you have any feedback on the changes I made and anything you want me to change. |
@brettcannon I think that all makes sense to me. The only bigger picture question I've got is around the use of the |
Possibly. I think that's a bigger question for the overall core team (something you want to bring up at the language summit?). |
BTW I left the |
I already have a slide for this (in the context of support for other Apple platforms). 😄 |
Uh oh!
There was an error while loading. Please reload this page.
The files in
Tools/wasm
are a little messy as nearly all Emscripten-related files are inemscripten/
while the WASI-related files are not. So I want to:wasi/
directory and move code related towasi.py
therewasi.py
a deprecated shim for callingwasi/
CODEOWNERS
such that @freakboy3742 isn't bothered about WASI-only stuff and I'm not bothered about Emscripten-only stuffThe text was updated successfully, but these errors were encountered: