Skip to content

PEP 739 / build-details.json: c_api.include is used instead of c_api.headers #134455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgorny opened this issue May 21, 2025 · 0 comments
Closed

PEP 739 / build-details.json: c_api.include is used instead of c_api.headers #134455

mgorny opened this issue May 21, 2025 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@mgorny
Copy link
Contributor

mgorny commented May 21, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

PEP 739 specifies that the CPython header directory is included in the c_api.headers key. However, it seems that the implemented that landed in #130069 uses c_api.include instead:

{
  ...
  "c_api": {
    "include": "/usr/include",
    "pkgconfig_path": "/usr/lib64/pkgconfig"
  }
}

I don't see any evidence that the name was changed deliberately. In fact, the code seems to be mixing both include and headers names:

cpython/Tools/build/generate-build-details.py

Line 126 in 1a07a01

data['c_api']['include'] = INCLUDEDIR

cpython/Tools/build/generate-build-details.py

Lines 138 to 145 in 1a07a01

PATH_KEYS = [
'base_interpreter',
'libpython.dynamic',
'libpython.dynamic_stableabi',
'libpython.static',
'c_api.headers',
'c_api.pkgconfig_path',
]

CPython versions tested on:

3.14, CPython main branch

Operating systems tested on:

Linux

Linked PRs
@mgorny mgorny added the type-bug An unexpected behavior, bug, or error label May 21, 2025
mgorny added a commit to mgorny/cpython that referenced this issue May 21, 2025
@mgorny
pythongh-134455: Fix build-details.json to use the `c_api.headers…
1abf897 
…` key

Fix `build-details.json` generation to use the correct `c_api.headers`
key as defined in PEP 739, instead of `c_api.include`.
@bedevere-app bedevere-app bot mentioned this issue May 21, 2025
Merged
mgorny added a commit to mgorny/cpython that referenced this issue May 21, 2025
@mgorny
Fix build-details.json to use the c_api.headers key (python#134455
d2dc338 
)

Fix `build-details.json` generation to use the correct `c_api.headers`
key as defined in PEP 739, instead of `c_api.include`.
FFY00 added a commit that referenced this issue May 22, 2025
@mgorny @FFY00
gh-134455: Fix build-details.json to use the c_api.headers key (#…
d706eb9 
…134456)

Fix `build-details.json` generation to use the correct `c_api.headers`
key as defined in PEP 739, instead of `c_api.include`.

Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2025
@mgorny @FFY00 @miss-islington
pythongh-134455: Fix build-details.json to use the `c_api.headers…
f553719 
…` key (pythonGH-134456)

Fix `build-details.json` generation to use the correct `c_api.headers`
key as defined in PEP 739, instead of `c_api.include`.
(cherry picked from commit d706eb9)

Co-authored-by: Michał Górny <mgorny@gentoo.org>
Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
@bedevere-app bedevere-app bot mentioned this issue May 22, 2025
Merged
hugovk pushed a commit that referenced this issue May 22, 2025
@miss-islington @mgorny @FFY00
[3.14] gh-134455: Fix build-details.json to use the ``c_api.headers…
59cb829 
…`` key (GH-134456) (#134504)

Co-authored-by: Michał Górny <mgorny@gentoo.org>
Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
@hugovk hugovk closed this as completed May 22, 2025
@mgorny mgorny mentioned this issue May 24, 2025
Open
lkollar pushed a commit to lkollar/cpython that referenced this issue May 26, 2025
@mgorny @FFY00 @lkollar
pythongh-134455: Fix build-details.json to use the `c_api.headers…
f06e547 
…` key (python#134456)

Fix `build-details.json` generation to use the correct `c_api.headers`
key as defined in PEP 739, instead of `c_api.include`.

Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgorny @hugovk