Skip to content

zstd should use Py_XSETREF #134885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JelleZijlstra opened this issue May 29, 2025 · 3 comments
Closed

zstd should use Py_XSETREF #134885

JelleZijlstra opened this issue May 29, 2025 · 3 comments
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 29, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

There is a theoretical crash path in the new zstd module that can be avoided with Py_XSETREF. PR incoming.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@JelleZijlstra JelleZijlstra added the type-bug An unexpected behavior, bug, or error label May 29, 2025
@bedevere-app bedevere-app bot mentioned this issue May 29, 2025
Merged
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 29, 2025
@JelleZijlstra
pythongh-134885: zstd: Use Py_XSETREF
3f30ed4
encukou pushed a commit that referenced this issue May 30, 2025
@JelleZijlstra
gh-134885: zstd: Use Py_XSETREF (GH-134886)
45c6c48
@ZeroIntensity ZeroIntensity added the extension-modules C modules in the Modules dir label May 30, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 30, 2025
@JelleZijlstra @miss-islington
pythongh-134885: zstd: Use Py_XSETREF (pythonGH-134886)
a761e08 
(cherry picked from commit 45c6c48)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue May 30, 2025
Merged
@ZeroIntensity ZeroIntensity added 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels May 30, 2025
@ZeroIntensity
Copy link
Member

cc @emmatyping (the fix is already merged, but I just thought you'd want to be aware of it)

encukou pushed a commit that referenced this issue May 30, 2025
@miss-islington @JelleZijlstra
[3.14] gh-134885: zstd: Use Py_XSETREF (GH-134886) (GH-134922)
f28f930 
(cherry picked from commit 45c6c48)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@encukou
Copy link
Member

encukou commented May 30, 2025

Thank you for the fix!

@encukou encukou closed this as completed May 30, 2025
@emmatyping
Copy link
Member

Yes thank you! TIL about Py_XSETREF!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@encukou @JelleZijlstra @emmatyping @ZeroIntensity