Skip to content

Implemented new 'class foo():pass' syntax #41802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
logistix mannequin opened this issue Apr 3, 2005 · 5 comments
Closed

Implemented new 'class foo():pass' syntax #41802

logistix mannequin opened this issue Apr 3, 2005 · 5 comments
Assignees
@nascheme
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@logistix
Copy link
Mannequin

logistix mannequin commented Apr 3, 2005

BPO 1176019
Nosy @brettcannon, @nascheme
Files
  • new_class_syntax.diff: patch for new syntax
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/nascheme'
closed_at = <Date 2005-04-15.02:19:04.000>
created_at = <Date 2005-04-03.21:47:09.000>
labels = ['interpreter-core']
title = "Implemented new 'class foo():pass' syntax"
updated_at = <Date 2005-04-15.02:19:04.000>
user = 'https://bugs.python.org/logistix'

    bugs.python.org fields:

    activity = <Date 2005-04-15.02:19:04.000>
actor = 'nascheme'
assignee = 'nascheme'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2005-04-03.21:47:09.000>
creator = 'logistix'
dependencies = []
files = ['6590']
hgrepos = []
issue_num = 1176019
keywords = ['patch']
message_count = 5.0
messages = ['48145', '48146', '48147', '48148', '48149']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'nascheme', 'logistix']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1176019'
versions = []
    @logistix
    Copy link
    Mannequin Author

    logistix mannequin commented Apr 3, 2005

    This patch implements the new 'class foo():pass' syntax
    for the ast branch. It also includes minor modifications
    required to run build graminit.c on windows machines.

    @logistix logistix mannequin closed this as completed Apr 3, 2005
    @logistix logistix mannequin assigned nascheme Apr 3, 2005
    @logistix logistix mannequin added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Apr 3, 2005
    @brettcannon
    Copy link
    Member

    Logged In: YES
    user_id=357491

    Do you know why graminit.c stopped working on Windows?
    Kurt's report on the merger didn't show any issues on
    Windows and so I wonder if the problem goes back to the main
    branch as well.

    @logistix
    Copy link
    Mannequin Author

    logistix mannequin commented Apr 4, 2005

    Logged In: YES
    user_id=699438

    graminit.c is generated by pgen.exe. This process isn't fully
    automated on a windows build (like I'm guessing it is on
    linux). There is a provided makefile that works with visual
    studio's nmake for windows users. It just referenced an older
    version of the python lib file (2.3 instead of 2.5).

    I presume this hasn't caused problems in the past becuase
    people modifying grammar/grammar have been running some
    form of *nix.

    Now I'm starting to wonder if pgen generates any other files
    (i.e. header files) that I didn't include in the patch. I'll verify
    when I get home.

    @logistix
    Copy link
    Mannequin Author

    logistix mannequin commented Apr 4, 2005

    Logged In: YES
    user_id=699438

    Just to confirm, pgen did generate a new graminit.h file, but
    there were no changes to it because we didn't add any new
    symbols. The patch I submitted is fine.

    @nascheme
    Copy link
    Member

    Logged In: YES
    user_id=35752

    Looks good. Check into the AST branch. Thanks for the patch.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @nascheme nascheme

    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @brettcannon @nascheme