-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Documentation is too personalized #62480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some documentation files contain a number of I/my/me. Looks like they grew from personal modules and personal articles. Perhaps the official documentation needs more depersonalized style. Here is full list of such files: Doc/c-api/exceptions.rst The list doesn't include FAQs where it may be appropriate and whatsnew files. Andrew Kuchling recently has fixed Doc/howto/unicode.rst for this issue (as part of bpo-4153). |
Here is a filtered results of find * -name '*.rst' -exec egrep -n -w -B1 -A1 'I|me|my' '{}' + |
I've looked through the matches. "I/O" and the -I command-line switch are false positives. Many references in the FAQ ("How do I do X?"), but those don't need to be fixed. I think personalized references are most problematic when they're expressing uncertainty ("I don't know if we implement all of the spec") or opinions. Sentences like "When I run this command under Linux, I see..." could be rewritten as "When *you* run this command...", but they don't seem worth fixing to me. Files with personalized text are: c-api/exceptions.rst |
I find some anonymous I references (Guido? 20 years ago?) off-putting when reading the doc as formal reference. |
The sockets tutorial deserves a good overhaul :-) |
Would it be OK for me to tackle this? |
Fred, do you want to opine on this? In some cases, like heapq.py, the personal touch is an essential and beautiful part of the presentation and is a cherished part of Python. In other cases, it seems unnecessary or a little off-putting, so perhaps a few changes are warranted. Personally, I've grown to really dislike the incessant stream of proposals to make broad sweeping trivial changes across the code or documentation to fix made-up problems (ones not reported or cared about by actual users). In particular, I worry about sending some new dev on a mission to rewrite documentation that was written by domain experts (Alex Martelli reported that copy-editors "wreaked havoc" on one of his books just prior to publication by subtly changing the meaning or correctness of his prose while applying grammar rules and minor style edits -- I wish to avoid the same for us). Also, I place high value on text written by Guido and think we lose something every time someone wants to rewrite it to fit their personal tastes and views of the language. The tastes and views of module authors are more important are easily lost in style edits (especially those that change point of view, mood, or theme of presentation). Another thought is that there should be different general rules for different sections. The standard library docs tend to be more formal. The language reference tends to be even more formal ("for language lawyers"). The tutorial tends to be personable. The how-to guides are often have a personal touch and are the only places where we attribute authorship back individuals (actual by-lines at the top of the file). [Cheryl Sabella]
|
What about WONTFIX here? I completely agree with rhettinger: this is a waste of time with potential for causing damage. |
Marking this as "easy". People are welcome to submit PRs that fix the wording in one or a small number of modules called out in Serhiy's list. |
I am taking a look at these, and I am sure there is a PEP I am unaware of - atm - so, a quick question. Is the double space at the end of a sentence 'required' by the rst processing, or is this also a 'personal' writing style in some of the documents (i.e., is replacing them with a single ' ', or otherwise, a new line ('\n') an error. iirc - new paragraphs are indicated by two new-lines. |
I think they are not required, but recommended. From https://www.python.org/dev/peps/pep-0008/#comments: You should use two spaces after a sentence-ending period in multi- sentence comments, except after the final sentence. From https://www.python.org/dev/peps/pep-0012/#general: You must adhere to the Emacs convention of adding two spaces at the end of every sentence. AFAIK in English typography the space after a sentence-ending period is longer than spaces between words. In other European typographies they have the same width. |
Thanks. afaik, double spacing is a 'feature' a programmer added to a On 26/07/2020 18:39, Serhiy Storchaka wrote:
I thought it was where type setters, classically, used the break between Anyway - final question: does .rst reformat line-lingths, or does it However, for now - double-spaces will remain - and I hope to remember to
|
I won't speak of nroff or troff in particular, but many programs had trouble distinguishing the end of a sentence from an honorific abbreviation, such as Mr. Spock or Dr. Seuss. |
@serhiy-storchaka, is this something you want to pursue, or should we close this as outdated? |
I think there are some things left:
It does not include examples with "I", because they have many false positives, but you can search them yourself using command: find * -name '*.rst' -exec egrep --color -n -w -B1 -A1 'I|me|my' '{}' + |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
Linked PRs
The text was updated successfully, but these errors were encountered: