Skip to content

Typo in __GNU*C*_MINOR__ guard affecting gcc 3.x #74122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
niklasf mannequin opened this issue Mar 28, 2017 · 3 comments
Closed

Typo in __GNU*C*_MINOR__ guard affecting gcc 3.x #74122

niklasf mannequin opened this issue Mar 28, 2017 · 3 comments
Labels
3.7 (EOL) end of life build The build process and cross-build

Comments

@niklasf
Copy link
Mannequin

niklasf mannequin commented Mar 28, 2017

BPO 29936
Nosy @tiran, @benjaminp, @niklasf
PRs
  • bpo-29936: fix typo __GNU*C*_MINOR__ #878
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2017-03-29.04:58:52.802>
created_at = <Date 2017-03-28.16:26:04.441>
labels = ['build', '3.7']
title = 'Typo in __GNU*C*_MINOR__ guard affecting gcc 3.x'
updated_at = <Date 2017-03-29.04:58:52.801>
user = 'https://github.com/niklasf'

    bugs.python.org fields:

    activity = <Date 2017-03-29.04:58:52.801>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2017-03-29.04:58:52.802>
closer = 'benjamin.peterson'
components = ['Build']
creation = <Date 2017-03-28.16:26:04.441>
creator = 'niklasf'
dependencies = []
files = []
hgrepos = []
issue_num = 29936
keywords = []
message_count = 3.0
messages = ['290738', '290767', '290768']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'benjamin.peterson', 'niklasf']
pr_nums = ['878']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue29936'
versions = ['Python 3.7']
    @niklasf
    Copy link
    Mannequin Author

    niklasf mannequin commented Mar 28, 2017

    The patch in http://bugs.python.org/issue16881 disables the nicer macro for gcc 3.x due to a small typo.

    The build is not failing. The guard just unnescessarily evaluates to false.

    @niklasf niklasf mannequin added interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.7 (EOL) end of life build The build process and cross-build and removed interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 28, 2017
    @benjaminp
    Copy link
    Contributor

    New changeset 83371f4 by Benjamin Peterson (Niklas Fiekas) in branch 'master':
    bpo-29936: fix typo __GNU*C*MINOR_ (#878)
    83371f4

    @benjaminp
    Copy link
    Contributor

    Thanks. We should probably just unsupport gcc 3.x.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @benjaminp