-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
build system runs when it may merely link #77665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The build system attempts to run certain test code when it can actually just link the code. This is a minor performance optimization but is really a semantic correctness issue. |
Thanks for wanting to improve Python. Your PR seems to contain quite a few changes that aren't obviously related to your topic. As for the topic, I know there are at least some cases where we really do have to *run* the code to prove the function is supported by the platform. That is, there are platforms that define the function but it doesn't actually work. I don't know if that applies to the things you are changing, and it will require input from people with more knowledge of the build system than I to confirm that your changes are a good idea. |
The unrelated changes are likely due to the "regen" step. I am using newer tools than previously used. It is unclear to me why we include generated files in the repository. Some projects prefer this to avoid the need to have autotools installed on the build machine. With regard to "some cases where we really do have to *run* the code to prove the function" you will notice that this is not a complete search and replace: I manually looked through the various uses of AC_RUN_IFELSE and only changed the ones that I thought should be changed. If someone has more knowledge of more arcane platforms and disagrees with my assessment, I will happily revert those changes. |
Yes, we are one of those projects that wants it to be possible to build python without having the tools that generate build artifacts. You will note that we also check in build artifacts that are produced by our own python scripts, to avoid the problem of trying to build python when you don't yet have a python. Please use the same version of autotools as were used to generate the current files. Upgrading autotools is done in a separate PR that only does the upgrade (and I don't know how we decide when to do that...) Actually, you could just generate the PR with the changes to the source files, not the build artifacte, for the initial review. |
I believe I have removed the regen step from all my patches. I will separately upgrade the generated files (particularly since it is only a minor version bump). |
Avoiding 4 processes (on runs without cache) is a very minor optimization indeed. And I don't see the semantic correctness -- surely we want the functions to not return an error indicator when called. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: