Skip to content

test_asyncio's GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher is not run #95010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graingert opened this issue Jul 19, 2022 · 4 comments
Closed

test_asyncio's GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcher is not run #95010

graingert opened this issue Jul 19, 2022 · 4 comments
Assignees
@graingert
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@graingert
Copy link
Contributor

graingert commented Jul 19, 2022 •
edited
Loading

Bug report
GenericWatcherTests does not inherit from TestCase, and so doesn't get run
@graingert graingert added the type-bug An unexpected behavior, bug, or error label Jul 19, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 19, 2022
Merged
graingert added a commit to graingert/cpython that referenced this issue Jul 19, 2022
@graingert
pythongh-95010: fix asyncio GenericWatcherTests.test_create_subproces…
20b9bd0 
…s_fails_with_inactive_watcher

the test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir easy and removed easy labels Jul 21, 2022
This was referenced Jul 21, 2022
Merged
Closed
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 21, 2022
@graingert @miss-islington
pythongh-95010: Fix asyncio GenericWatcherTests.test_create_subproces…
3b4ee85 
…s_fails_with_inactive_watcher (pythonGH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
serhiy-storchaka pushed a commit that referenced this issue Jul 21, 2022
@graingert
gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail…
834bd5d 
…s_with_inactive_watcher (GH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 21, 2022
@graingert @miss-islington
pythongh-95010: Fix asyncio GenericWatcherTests.test_create_subproces…
0bf111e 
…s_fails_with_inactive_watcher (pythonGH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington added a commit that referenced this issue Jul 21, 2022
@miss-islington @graingert
gh-95010: Fix asyncio GenericWatcherTests.test_create_subprocess_fail…
d19b5d8 
…s_with_inactive_watcher (GH-95009)

The test was never run, because it was missing the TestCase class.
The test failed because the wrong attribute was patched.
(cherry picked from commit 834bd5d)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 21, 2022
Closed
@Akuli
Copy link
Contributor

Akuli commented Jul 21, 2022

There seems to be quite a few classes like this:

$ git grep 'class .*Tests:' Lib/test/ | wc -l
94

@graingert
Copy link
Contributor Author

There seems to be quite a few classes like this:

$ git grep 'class .*Tests:' Lib/test/ | wc -l
94

I think some of those are supposed to be Mixins, but perhaps they should be re-named *Mixin: instead of *Tests:

@graingert graingert mentioned this issue Aug 3, 2022
Closed
@kumaraditya303
Copy link
Contributor

@graingert Is this fixed now? if not can you create a separate PR to just fix this ?

@graingert
Copy link
Contributor Author

I was going to backport it to 3.10 but the change ended up too controversial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graingert graingert

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graingert @serhiy-storchaka @Akuli @kumaraditya303