Skip to content

testcapimodule uses wrong format chars for datetime tests #95878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tiran opened this issue Aug 11, 2022 · 1 comment
Closed

testcapimodule uses wrong format chars for datetime tests #95878

tiran opened this issue Aug 11, 2022 · 1 comment
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Aug 11, 2022

Bug report

_testcapimodule.c has a similar bug as #95876. It uses l (long) format char for ints. This works ok on most platforms but causes memory corruption on WASM64.
@tiran tiran added type-bug An unexpected behavior, bug, or error 3.11 only security fixes 3.12 only security fixes labels Aug 11, 2022
tiran added a commit to tiran/cpython that referenced this issue Aug 11, 2022
@tiran
pythongh-95878: Fix format char in datetime CAPI tests
7f05173
@bedevere-bot bedevere-bot mentioned this issue Aug 11, 2022
Merged
tiran added a commit that referenced this issue Aug 11, 2022
@tiran
gh-95878: Fix format char in datetime CAPI tests (GH-95879)
8b34e91
@bedevere-bot bedevere-bot mentioned this issue Aug 11, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 11, 2022
@tiran @miss-islington
pythongh-95878: Fix format char in datetime CAPI tests (pythonGH-95879)
bb8e6e0 
(cherry picked from commit 8b34e91)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Aug 11, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 11, 2022
@tiran @miss-islington
pythongh-95878: Fix format char in datetime CAPI tests (pythonGH-95879)
9f43a6c 
(cherry picked from commit 8b34e91)

Co-authored-by: Christian Heimes <christian@python.org>
pablogsal pushed a commit that referenced this issue Aug 11, 2022
@miss-islington @tiran
gh-95878: Fix format char in datetime CAPI tests (GH-95879) (#95885)
731732a 
(cherry picked from commit 8b34e91)

Co-authored-by: Christian Heimes <christian@python.org>

Co-authored-by: Christian Heimes <christian@python.org>
miss-islington added a commit that referenced this issue Aug 11, 2022
@miss-islington @tiran
gh-95878: Fix format char in datetime CAPI tests (GH-95879)
9c04e25 
(cherry picked from commit 8b34e91)

Co-authored-by: Christian Heimes <christian@python.org>
@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Nov 25, 2023
@erlend-aasland erlend-aasland added the 3.13 bugs and security fixes label Jan 4, 2024
@erlend-aasland
Copy link
Contributor

Fixed by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tiran @iritkatriel @erlend-aasland