Skip to content

gh-99892: test_unicodedata: skip test on download failure #100011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

gh-99892: test_unicodedata: skip test on download failure #100011

merged 1 commit into from
Dec 5, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 5, 2022 •
edited by bedevere-bot
Loading

Skip test_normalization() of test_unicodedata if it fails to download NormalizationTest.txt file from pythontest.net.

@vstinner
gh-99892: test_unicodedata: skip test on download failure
ff9037e 
Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
@vstinner vstinner added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 5, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2022
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Dec 5, 2022
@vstinner vstinner merged commit 2488c1e into python:main Dec 5, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_unicodedata branch December 5, 2022 15:37
@miss-islington
Copy link
Contributor

Sorry @vstinner, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 2488c1e1b66366a3a933ff248eff080fabd2351c 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@vstinner @miss-islington
pythongh-99892: test_unicodedata: skip test on download failure (pyth…
fccc115 
…onGH-100011)

Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-100012 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 5, 2022
@vstinner vstinner added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Dec 5, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100013 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
@vstinner @miss-islington
pythongh-99892: test_unicodedata: skip test on download failure (pyth…
4521373 
…onGH-100011)

Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Dec 5, 2022
@miss-islington @vstinner
gh-99892: test_unicodedata: skip test on download failure (GH-100011)
c067023 
Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Dec 5, 2022
@miss-islington @vstinner
gh-99892: test_unicodedata: skip test on download failure (GH-100011)
4a7612f 
Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <vstinner@python.org>
@benjaminp
Copy link
Contributor

Why not add retries to the fetch? I'm afraid this will silently disable the test forever if fetching the file becomes a permanent error.

@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2022

Hi @benjaminp,

Why not add retries to the fetch?

My reason: I want to limit time spent on this issue :-) I only worked on it because I'm getting 1 to 5 emails per day related to test_unicodedata failures, but only on some workers which have other network issues. If someone else is volunteer to enhance the code, please go ahead ;-) A generic function "download a file from the Internet, retry on error, and skip the test after a timeout" sounds like an useful feature ;-)

@benjaminp
Copy link
Contributor

I very much understand not wanting to spend time. But, as I said, I'm afraid this could have scary side-effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vstinner vstinner

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @miss-islington @bedevere-bot @benjaminp