Skip to content

bpo-35054: Add more index entries for symbols. #10064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2018
Merged

bpo-35054: Add more index entries for symbols. #10064

merged 2 commits into from
Oct 26, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 23, 2018 •
edited by bedevere-bot
Loading

matrixise
matrixise approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @serhiy-storchaka

You can merge your PR, I have just checked on my laptop, the rendering of the index page is fine and the links work.

Good idea.

vstinner
vstinner approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

"space" goes to the S-Index as "space" (in letters), not as a whitespace. But that's ok. It shouldn't block your PR ;-)

There are a few entries which have the same symbol and same description like os.curdir and os.extsep, but that's ok as well.

Doc/library/string.rst
.. index::
single: +; in string formatting
single: -; in string formatting
single: space; in string formatting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly "space" goes to https://docs.python.org/dev/genindex-S.html as "space", not as a whitespace. But that's ok ;-)

pablogsal
pablogsal reviewed Oct 26, 2018
View reviewed changes
Doc/reference/simple_stmts.rst Outdated
@@ -112,6 +112,12 @@ unacceptable. The rules observed by various types and the exceptions raised are
given with the definition of the object types (see section :ref:`types`).

.. index:: triple: target; list; assignment
single: ,; in target list
single: *; in assiggnment target list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/assiggnment/assignment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@serhiy-storchaka serhiy-storchaka merged commit ddb961d into python:master Oct 26, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the index-symbols branch October 26, 2018 06:00
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ddb961d2abe5d5fde76d85b21a77e4e91e0043ad 3.7

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ddb961d2abe5d5fde76d85b21a77e4e91e0043ad 3.6

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 26, 2018
@serhiy-storchaka
[3.7] bpo-35054: Add more index entries for symbols. (pythonGH-10064).
6c746f8 
(cherry picked from commit ddb961d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 26, 2018
@serhiy-storchaka
[3.6] bpo-35054: Add more index entries for symbols. (pythonGH-10064).
0475465 
(cherry picked from commit ddb961d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-10119 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-10120 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Oct 26, 2018
@serhiy-storchaka
[3.7] bpo-35054: Add more index entries for symbols. (GH-10064). (GH-…
9a75b84 
…10120)

(cherry picked from commit ddb961d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 26, 2018
@serhiy-storchaka
[3.6] bpo-35054: Add more index entries for symbols. (GH-10064). (GH-…
e825b4e 
…10119)

(cherry picked from commit ddb961d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal left review comments

@matrixise matrixise matrixise approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@serhiy-storchaka @miss-islington @bedevere-bot @matrixise @vstinner @pablogsal @the-knights-who-say-ni