Skip to content

Revert "bpo-35059 : Add /Ob1 flag when building pythoncore in debug mode" #10127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Revert "bpo-35059 : Add /Ob1 flag when building pythoncore in debug mode" #10127

wants to merge 3 commits into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 26, 2018 •
edited by bedevere-bot
Loading

@vstinner vstinner requested a review from a team as a code owner October 26, 2018 13:52
@vstinner
Copy link
Member Author

My PR broke most Windows buildbots :-( So I revert it, to get time to understand why.

@vstinner
Copy link
Member Author

Hum, I'm trying a different solution: fix libmpdec, PR #10128.

@vstinner
Copy link
Member Author

Abandonned, it seems like PR #10128 fixed the compilation.

@vstinner vstinner closed this Oct 26, 2018
@vstinner vstinner deleted the revert-10094-msvc_Ob1 branch October 26, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot