bpo-35059, libmpdec: Add missing EXTINLINE in mpdecimal.h #10128
Conversation
Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1.
|
"Build AMD64 Windows7 SP1 custom #3 is complete: Success" Good! That's the one buildbot (AMD64 Windows7 SP1 3.x) where the compilation failed! |
|
@skrah: I'm sorry, I couldn't wait for your review since I broke most Windows buildbots and I wanted to fix the CI as soon as possible, since I have more PRs to push in https://bugs.python.org/issue35059 and I would like to make sure that they don't break anything! I tried to find how to propose this change upstream, but I failed to find a (git, hg, svn, ...) repository, not a document explaining how to contribute to libmpdec. If you dislike this change, maybe I can revert it and I can change the configuration of the "_decimal" project in the Visual Studio solution to not compile it with /Ob1 in Debug mode (only this project). But it looks like a bug in libmpdec.h, since all other functions implemented with inline or ALWAYS_INLINE are already declared with EXTINLINE. Maybe the compiler is smarter and doesn't cause the linker bug in Release mode. No idea why the bug only occurs on specific Windows buildbots (not on AppVeyor, not on my Windows VM, not on Linux, etc.) Linker bug fixed by this PR: |
|
I will wait to double check that this change really fix all Windows buildbots. Then the question is if the change should be backported to 3.6 and 3.7. |
|
I checked buildbots: my change fixed all Windows buildbots, good. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-10134 is a backport of this pull request to the 3.6 branch. |
|
GH-10135 is a backport of this pull request to the 3.7 branch. |
…0128) Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1. (cherry picked from commit 3b1cba3) Co-authored-by: Victor Stinner <vstinner@redhat.com>
…0128) Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1. (cherry picked from commit 3b1cba3) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1. (cherry picked from commit 3b1cba3) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Declare functions with EXTINLINE: * mpd_del() * mpd_uint_zero() * mpd_qresize() * mpd_qresize_zero() * mpd_minalloc() These functions are implemented with "inline" or "ALWAYS_INLINE", but declared without inline which cause linker error on Visual Studio in Debug mode when using /Ob1. (cherry picked from commit 3b1cba3) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Declare functions with EXTINLINE:
These functions are implemented with "inline" or "ALWAYS_INLINE", but
declared without inline which cause linker error on Visual Studio in
Debug mode when using /Ob1.
https://bugs.python.org/issue35059