Skip to content

gh-101522: Allow overriding Windows dependencies versions and paths using MSBuild properties #101523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

gh-101522: Allow overriding Windows dependencies versions and paths using MSBuild properties #101523

merged 1 commit into from
Feb 3, 2023

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 2, 2023 •
edited by bedevere-bot
Loading

@zooba zooba requested a review from a team as a code owner February 2, 2023 23:44
@bedevere-bot bedevere-bot mentioned this pull request Feb 2, 2023
Closed
@zooba zooba added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 3, 2023
@zooba
Copy link
Member Author

zooba commented Feb 3, 2023

We should backport this to avoid making it a real pain to backport changes when we update these versions.

@zooba zooba merged commit f6c53b8 into python:main Feb 3, 2023
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f6c53b80a16f63825479c5ca0f8a5e2829c3f505 3.11

@zooba zooba deleted the overrides branch February 3, 2023 18:08
@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker f6c53b80a16f63825479c5ca0f8a5e2829c3f505 3.10

@bedevere-bot
Copy link

GH-101546 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 3, 2023
@bedevere-bot
Copy link

GH-101547 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 3, 2023
zooba added a commit to zooba/cpython that referenced this pull request Feb 3, 2023
@zooba
pythongh-101522: Allow overriding Windows dependencies versions and p…
daecdcb 
…aths using MSBuild properties (pythonGH-101523)
zooba added a commit that referenced this pull request Feb 3, 2023
@zooba
gh-101522: Allow overriding Windows dependencies versions and paths u…
898de13 
…sing MSBuild properties (GH-101523)
zooba added a commit that referenced this pull request Feb 3, 2023
@zooba
gh-101522: Allow overriding Windows dependencies versions and paths u…
3139ea3 
…sing MSBuild properties (GH-101523)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zooba @miss-islington @bedevere-bot