Skip to content

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Feb 5, 2023

This PR is an attempt to fix the buildbot failures introduced by my merge of #5561, by restricting the relevant tests to something that should work on both 32-bit and 64-bit platforms.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 3586c09 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2023
Copy link
Contributor

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If this fails too then I guess we should just only run the tests of PEP3118 when we know the actual memory layout (according to the ctypes module) is what we expected, and otherwise skip then

@mdickinson
Copy link
Member Author

Argh. Windows wants 'T{<b:x:3x<L:y:}' rather than 'T{<b:x:3x<I:y:}'.

@mdickinson
Copy link
Member Author

Added a couple of commits to silence warnings.

@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit f273e74 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2023
@@ -355,8 +355,8 @@ _ctypes_alloc_format_padding(const char *prefix, Py_ssize_t padding)
return _ctypes_alloc_format_string(prefix, "x");
}

int ret = PyOS_snprintf(buf, sizeof(buf), "%zdx", padding);
assert(0 <= ret && ret < sizeof(buf));
int ret = PyOS_snprintf(buf, sizeof(buf), "%zdx", padding); (void)ret;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, the (void)ret; trick comes from the LLVM Coding Standard: https://llvm.org/docs/CodingStandards.html#assert-liberally

@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 59144e7 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 5, 2023
@mdickinson
Copy link
Member Author

One buildbot failure, for buildbot/aarch64 RHEL8 Refleaks PR, which looks unrelated (test_importlib and test_asyncio failures).

@eric-wieser This seems to be working; do you have time to give this a second-pass review?

Copy link
Contributor

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@mdickinson mdickinson merged commit 46416b9 into python:main Feb 6, 2023
@mdickinson mdickinson deleted the fix-test-pep3118-buildbot-failures branch February 6, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants