-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-76961: Possible fix for buildbot failures in test_pep3118 #101587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-76961: Possible fix for buildbot failures in test_pep3118 #101587
Conversation
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 3586c09 🤖 If you want to schedule another build, you need to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! If this fails too then I guess we should just only run the tests of PEP3118 when we know the actual memory layout (according to the ctypes module) is what we expected, and otherwise skip then
Argh. Windows wants |
Added a couple of commits to silence warnings. |
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit f273e74 🤖 If you want to schedule another build, you need to add the |
@@ -355,8 +355,8 @@ _ctypes_alloc_format_padding(const char *prefix, Py_ssize_t padding) | |||
return _ctypes_alloc_format_string(prefix, "x"); | |||
} | |||
|
|||
int ret = PyOS_snprintf(buf, sizeof(buf), "%zdx", padding); | |||
assert(0 <= ret && ret < sizeof(buf)); | |||
int ret = PyOS_snprintf(buf, sizeof(buf), "%zdx", padding); (void)ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, the (void)ret;
trick comes from the LLVM Coding Standard: https://llvm.org/docs/CodingStandards.html#assert-liberally
🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 59144e7 🤖 If you want to schedule another build, you need to add the |
One buildbot failure, for buildbot/aarch64 RHEL8 Refleaks PR, which looks unrelated ( @eric-wieser This seems to be working; do you have time to give this a second-pass review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
This PR is an attempt to fix the buildbot failures introduced by my merge of #5561, by restricting the relevant tests to something that should work on both 32-bit and 64-bit platforms.