Skip to content

gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence #101698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 15, 2023
Merged

gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence #101698

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b693895
gh-101698: Deprecate using named placeholders with sequences
erlend-aasland Feb 8, 2023
483e4d6
Update docs
erlend-aasland Feb 8, 2023
e826428
Document deprecation in reference
erlend-aasland Feb 8, 2023
132a6ee
Also test executemany
erlend-aasland Feb 8, 2023
31cc188
Revert "Also test executemany"
erlend-aasland Feb 8, 2023
660a742
Sync with main
erlend-aasland Feb 9, 2023
a18d0bb
Address review: add test for query with more than one named param
erlend-aasland Feb 9, 2023
3f94201
Address review: add PyErr_WarnFormat error handling
erlend-aasland Feb 9, 2023
997ccc6
Sync with main
erlend-aasland Feb 10, 2023
cb091af
Pull in main
erlend-aasland Feb 14, 2023
450cdcc
Fixup
erlend-aasland Feb 14, 2023
841e8a4
Apply Serhiy's suggestion
erlend-aasland Feb 14, 2023
3e7b680
Pull in main
erlend-aasland Feb 14, 2023
38d1110
Address Alex's review
erlend-aasland Feb 14, 2023
cf3cfc8
Also amend NEWS and What's New
erlend-aasland Feb 14, 2023
1687b65
Use deprecated-removed
erlend-aasland Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: add test for query with more than one named param
  • Loading branch information
@erlend-aasland
erlend-aasland committed Feb 9, 2023
commit a18d0bb690aa8487d868b82493caa04f9729b33c
1 change: 1 addition & 0 deletions Lib/test/test_sqlite3/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ def test_execute_named_param_and_sequence(self):
("select :a, ?, ?", (1, 2, 3)),
("select ?, :b, ?", (1, 2, 3)),
("select ?, ?, :c", (1, 2, 3)),
("select :a, :b, ?", (1, 2, 3)),
)
msg = "Binding.*is a named parameter"
for query, params in dataset:
Expand Down