gh-71587: Clear cached strptime module #101783
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abalkin
commented
Feb 10, 2023
•
- Issue: Datetime NoneType after calling Py_Finalize and Py_Initialize #71587
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
abalkin
commented
Feb 10, 2023
Modules/_datetimemodule.c
Outdated
| @@ -6863,12 +6864,17 @@ _datetime_exec(PyObject *module) | |||
| return 0; | |||
| } | |||
|
|
|||
| static void module_free(void*) { | |||
| strptime_module = NULL; | |||
There was a problem hiding this comment.
We should call Py_CLEAR here to avoid leaking a reference.
|
This approach isn't going to be any better than the existing one. It needs to be written in a way that doesn't use global variables at all ( |
|
This can be closed, the issue is complete. |
|
The following commit authors need to sign the Contributor License Agreement: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.