Optimize fmean() weighted average #102626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
math.sumprod()
function to compute the weighted average.As compared to
fsum(map(mul, data, weights))
thesumprod(data, weights)
code is simpler, faster, and more accurate. It is faster because we don't need a succession of calls tomul
. It is more accurate because all of the intermediate products are computed losslessly rather than rounded immedately bymul
. Also, we no longer need thecount()
wrapper for this path becausesumprod()
already incorporates a test to make sure the inputs are the same length.Baseline timing
% ./python.exe -m timeit -r11 -s 'from random import expovariate as r' -s 'from statistics import fmean' -s 'n=100' -s 'data = [r() for i in range(n)]' -s 'weights = [r() for i in range(n)]' 'fmean(data, weights)'
50000 loops, best of 11: 4.96 usec per loop
Improved timing
% ./python.exe -m timeit -r11 -s 'from random import expovariate as r' -s 'from statistics import fmea
n' -s 'n=100' -s 'data = [r() for i in range(n)]' -s 'weights = [r() for i in range(n)]' 'fmean(data, weights)'
100000 loops, best of 11: 2.06 usec per loop