Skip to content

gh-102840: Fix confused traceback when floordiv or mod operations happens between Fraction and complex objects #102842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 10, 2024
Merged

gh-102840: Fix confused traceback when floordiv or mod operations happens between Fraction and complex objects #102842

merged 10 commits into from
Feb 10, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Mar 20, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Mar 20, 2023
Closed
@Eclips4
Copy link
Member Author

Eclips4 commented Mar 20, 2023

cc @skirpichev

skirpichev
skirpichev requested changes Mar 20, 2023
View reviewed changes
@Eclips4 Eclips4 requested a review from skirpichev March 20, 2023 12:36
skirpichev
skirpichev requested changes Mar 20, 2023
View reviewed changes
@Eclips4 @skirpichev
Add sugestion from skirpichev
b03522e 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@Eclips4
Copy link
Member Author

Eclips4 commented Mar 20, 2023

Also, I think there no need in NEWS entry. But if someone want it - I'll add it.

skirpichev
skirpichev approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arhadthedev arhadthedev added the stdlib Python modules in the Lib dir label Mar 22, 2023
@arhadthedev
Copy link
Member

@mdickinson (as a fraction expert)

Eclips4
Eclips4 commented Jan 1, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that silencing TypeError for any operation is right. It can silence some unexpected errors, it is also not very efficient. It would be better to just not try to perform unsupported operation. I suggest to add an optional parameter in _operator_fallbacks() to specify whether try to handle complex numbers or not. We know which operations are not supported by complex.

@mdickinson
Copy link
Member

I suggest to add an optional parameter in _operator_fallbacks() to specify whether try to handle complex numbers or not.

+1. This sounds like the right approach to me.

@Eclips4
Copy link
Member Author

Eclips4 commented Feb 10, 2024

Do we need NEWS entry here? It's improves the user experience, so in my opinion - yes.

serhiy-storchaka
serhiy-storchaka reviewed Feb 10, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a user visible change, so a NEWS entry will not make bad.

It will help if users wonder about confusing error messages in older Python.

skirpichev
skirpichev approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo minor nitpick about default value.

@Eclips4 @serhiy-storchaka
Update Misc/NEWS.d/next/Library/2024-02-10-15-24-20.gh-issue-102840.4…
489b95d 
…mnDq1.rst

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit 5319c66 into python:main Feb 10, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@Eclips4 @fsc-eriker
pythongh-102840: Fix confused traceback when floordiv or mod operatio…
bec39e4 
…ns happens between Fraction and complex objects (pythonGH-102842)
scoder added a commit to scoder/quicktions that referenced this pull request Nov 28, 2024
@scoder
Prevent 'complex' handling in division methods.
302375b 
See python/cpython#102842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Eclips4 @arhadthedev @mdickinson @skirpichev @serhiy-storchaka @bedevere-bot