Skip to content

gh-102140: fix false negative in csv.Sniffer.has_header #103341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
+36 −2
Open

gh-102140: fix false negative in csv.Sniffer.has_header #103341

Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
60d7501
fixing has_header
johnD18 Mar 27, 2023
1636e7b
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo Apr 7, 2023
7020dd5
Merge branch 'main' into has_header_false_neg_fix
Drakariboo Apr 7, 2023
e2a76d9
adding genericalias
johnD18 Apr 7, 2023
02b645d
adding fieldnames
johnD18 Apr 7, 2023
747cbc8
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 Apr 7, 2023
6db356f
correcting deletions
johnD18 Apr 7, 2023
38166fe
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 Apr 11, 2023
2fe30c0
correction of comments
johnD18 Apr 11, 2023
b78cd78
corrections
johnD18 Apr 11, 2023
9ce92ba
adding the deleted line (if isinstance(colType, int): # it's a length)
johnD18 Apr 11, 2023
ccf9d2e
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 1, 2023
8ae2789
correcting...
johnD18 May 1, 2023
90c70b4
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 1, 2023
1c2fef7
Update Lib/csv.py
johnD18 May 1, 2023
ba6083c
Update Lib/csv.py
johnD18 May 1, 2023
2b8c27e
Update Lib/csv.py
johnD18 May 1, 2023
7ba8c83
Update Lib/csv.py
johnD18 May 1, 2023
92f63f6
Update Lib/csv.py
johnD18 May 1, 2023
a1d84d6
Update Lib/csv.py
johnD18 May 1, 2023
ca440f7
Update Lib/csv.py
johnD18 May 1, 2023
f60bc70
Update Lib/csv.py
johnD18 May 1, 2023
22d8b55
Update Lib/csv.py
johnD18 May 1, 2023
2852554
Update Lib/csv.py
johnD18 May 1, 2023
1a9ed20
restore blank lines
merwok May 1, 2023
d381110
Apply suggestions from code review
johnD18 May 1, 2023
3384c99
📜🤖 Added by blurb_it.
blurb-it[bot] May 1, 2023
e306d93
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 6, 2023
d167d6d
test for issue #102140
johnD18 May 6, 2023
17d4a7e
adding space
johnD18 May 6, 2023
95c1dae
patch check correction
johnD18 May 6, 2023
b978f18
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 6, 2023
d7d2be5
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 10, 2023
d8f180e
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo May 10, 2023
eb80cbb
rephrase comment line 449
Drakariboo May 10, 2023
3c62566
doc in csv.rst improved for has_header function
Drakariboo May 10, 2023
9754874
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 10, 2023
e1f3e1b
delete whitespace in csv.rst
Drakariboo May 10, 2023
891b657
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo May 10, 2023
d01e7a4
delete the final whitespaces
Drakariboo May 10, 2023
a390543
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 13, 2023
57c58ce
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo May 13, 2023
42c00e1
merged the 2 loops line 400
Drakariboo May 13, 2023
84b6dda
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 13, 2023
6950c1e
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 15, 2023
bffbcf7
Update Lib/test/test_csv.py
johnD18 May 15, 2023
b3d0bf2
update csv.py
johnD18 May 15, 2023
b6a557c
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 16, 2023
8561127
Merge branch 'python:main' into has_header_false_neg_fix
Drakariboo May 17, 2023
04ee833
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 22, 2023
a0a5544
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 27, 2023
0ab2649
updating csv.rst
johnD18 May 27, 2023
1d63e98
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 28, 2023
5aabf60
whatsnew update
johnD18 May 28, 2023
61dfb3e
whatsnew update
johnD18 May 28, 2023
34e52fa
whatsnew update
johnD18 May 28, 2023
d0f33be
resolve conflict
johnD18 May 29, 2023
8fe8b7c
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 29, 2023
3e2b806
misc/news update
johnD18 May 29, 2023
2e8d2f2
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 29, 2023
b77dc4c
Update Misc/NEWS.d/next/Library/2023-05-01-18-53-20.gh-issue-102140._…
johnD18 May 29, 2023
bb136bb
adding a comment on csv.py & csv.rst update
johnD18 May 29, 2023
dcf1af4
Merge branch 'main' into has_header_false_neg_fix
Drakariboo May 30, 2023
920cc1e
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 30, 2023
1971df6
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 31, 2023
8746e64
Merge branch 'main' into has_header_false_neg_fix
johnD18 May 31, 2023
a9ea1be
Merge branch 'main' into has_header_false_neg_fix
Drakariboo May 31, 2023
6d139a6
Merge branch 'python:main' into has_header_false_neg_fix
johnD18 May 31, 2023
141cf5d
Merge branch 'main' into has_header_false_neg_fix
Drakariboo Jun 14, 2023
9686653
Update Lib/csv.py
Drakariboo Jun 15, 2023
680c67b
Update Misc/NEWS.d/next/Library/2023-05-01-18-53-20.gh-issue-102140._…
Drakariboo Jun 15, 2023
149938a
Update Lib/csv.py
Drakariboo Jun 15, 2023
4b22c77
Update Lib/csv.py
Drakariboo Jun 15, 2023
2092173
Update Lib/csv.py
Drakariboo Jun 15, 2023
95f2b61
Merge branch 'main' into has_header_false_neg_fix
Drakariboo Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'python:main' into has_header_false_neg_fix
  • Loading branch information
@johnD18
johnD18 authored May 31, 2023
commit 1971df680e14facc1b3d17a3f68db0e6543f3f88

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.