Skip to content

Update subprocess.Popen documentation wrt universal_newlines arg #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2018
Merged

Update subprocess.Popen documentation wrt universal_newlines arg #10337

merged 1 commit into from
Nov 12, 2018

Conversation

jstasiak
Copy link
Contributor

@jstasiak jstasiak commented Nov 5, 2018

  • universal_newlines defaulting to False would suggest, that not
    specifying universal_newlines explicitly and setting text to True
    should cause an error, which is not the case.
  • The run function didn't have the universal_newlines parameter
    documented
  • The check_output function didn't have its text parameter documented

@jstasiak
Update subprocess documentation to better reflect reality
b87be8e 
* universal_newlines defaulting to False would suggest, that not
  specifying universal_newlines explicitly and setting text to True
  should cause an error, which is not the case.
* The run function didn't have the universal_newlines parameter
  documented
* The check_output function didn't have its text parameter documented
@jstasiak jstasiak requested a review from gpshead as a code owner November 5, 2018 16:23
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 5, 2018
@Mariatta Mariatta changed the title Update subprocess documentation to better reflect reality Update subprocess.Popen documentation wrt universal_newlines arg Nov 12, 2018
@miss-islington miss-islington merged commit 7432f09 into python:master Nov 12, 2018
@miss-islington
Copy link
Contributor

Thanks @jstasiak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10475 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2018
@jstasiak @miss-islington
Update subprocess.Popen documentation wrt universal_newlines arg (pyt…
0764318 
…honGH-10337)

* universal_newlines defaulting to False would suggest, that not
  specifying universal_newlines explicitly and setting text to True
  should cause an error, which is not the case.
* The run function didn't have the universal_newlines parameter
  documented
* The check_output function didn't have its text parameter documented
(cherry picked from commit 7432f09)

Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
miss-islington added a commit that referenced this pull request Nov 12, 2018
@miss-islington @jstasiak
Update subprocess.Popen documentation wrt universal_newlines arg (GH-…
7a90504 
…10337)

* universal_newlines defaulting to False would suggest, that not
  specifying universal_newlines explicitly and setting text to True
  should cause an error, which is not the case.
* The run function didn't have the universal_newlines parameter
  documented
* The check_output function didn't have its text parameter documented
(cherry picked from commit 7432f09)

Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jstasiak @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni