gh-103242: Migrate SSLContext.set_ecdh_curve not to use deprecated APIs #103378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corona10
commented
Apr 8, 2023
•
- Issue: Can't build '_ssl' extension with Python 3.11.2 and OpenSSL 3.1 #103242
(.oss) corona10@CPython-devel:~/cpython$ ./python -m test test_ssl -R 3:3
0:00:00 load avg: 0.04 Run tests sequentially
0:00:00 load avg: 0.04 [1/1] test_ssl
beginning 6 repetitions
123456
......
test_ssl passed in 1 min 14 sec
== Tests result: SUCCESS ==
1 test OK.
Total duration: 1 min 14 sec
Tests result: SUCCESS |
gpshead
approved these changes
Apr 8, 2023
There was a problem hiding this comment.
I had to do a pile of searching and reading of the OpenSSL docs to understand that this is the correct modern way to do this. Thanks for the cleanup. I think there are compiler defines that can be set to still use the old deprecated APIs, but we shouldn't. That might be a viable strategy for anyone attempting to build 3.10 or earlier against an openssl recent enough to hide them by default though.
|
GH-103382 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 8, 2023
…ted APIs (pythonGH-103378) Migrate `SSLContext.set_ecdh_curve()` not to use deprecated OpenSSL APIs. (cherry picked from commit 3516704) Co-authored-by: Dong-hee Na <donghee.na@python.org>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…ted APIs (python#103378) Migrate `SSLContext.set_ecdh_curve()` not to use deprecated OpenSSL APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.