Skip to content

Fix old behaviour in typing documentation #103400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2023
Merged

Fix old behaviour in typing documentation #103400

merged 1 commit into from
Apr 9, 2023

Conversation

Gobot1234
Copy link
Contributor

@Gobot1234 Gobot1234 commented Apr 9, 2023 •
edited
Loading 

>>> class Z(Generic[T, P]): ...
... 
>>> Z[int, [dict, float]]
__main__.Z[int, [dict, float]]

Related to #102637

@Gobot1234
Fix old behaviour in documentation
987dbed 
>>> class Z(Generic[T, P]): ...
... 
>>> Z[int, [dict, float]]
__main__.Z[int, [dict, float]]
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 9, 2023
@Gobot1234
Copy link
Contributor Author

Should this be backported to 3.11? It doesn't look like the original fix was

@AlexWaygood
Copy link
Member

Good point

@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label Apr 9, 2023
AlexWaygood
AlexWaygood approved these changes Apr 9, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably change it so that these REPL snippets are actually run as part of CPython's doctest suite. But that can wait.

@AlexWaygood AlexWaygood merged commit ecad802 into python:main Apr 9, 2023
@Gobot1234 Gobot1234 deleted the patch-1 branch April 9, 2023 22:12
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@Gobot1234 @warsaw
Fix old behaviour in typing documentation (python#103400)
c798fd7
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@Gobot1234 @aisk
Fix old behaviour in typing documentation (python#103400)
fec2624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gobot1234 @AlexWaygood @bedevere-bot