Skip to content

gh-67044: csv.QUOTE_MINIMAL minor Doc improvements #104118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-67044: csv.QUOTE_MINIMAL minor Doc improvements #104118

wants to merge 2 commits into from

Conversation

vcapparelli
Copy link

@vcapparelli vcapparelli commented May 3, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 3, 2023
Open
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels May 3, 2023
@ghost
Copy link

ghost commented May 3, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@serhiy-storchaka
Copy link
Member

@bitdancer, please take a look, it is an implementation of your suggestion.

Note that quotechar only requires quoting if doublequote is true.

serhiy-storchaka
serhiy-storchaka reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithm for quoting is more complex, for example empty strings and None can be quoted in some circumstances to avoid ambiguity. Accurate description of the algorithm would be too complex too, and have a risk of desynchronizing from the implementation.

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcapparelli @serhiy-storchaka @bedevere-bot