-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
dict insertion order is guaranteed since 3.7 #10431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think auto merge is not triggered here since 2 checks fail with issue number and news entry. Maybe adding skip-news and skip-issue labels will help. |
I don't think so, this PR #10098 didn't have those labels and it was automerged. |
The linked PR had both an issue number and a NEWS entry so it didn't require those labels and all checks passed. skip label is required when there is no issue in title and adding it makes the check pass and same for skip news. I hope it's the reason auto merge doesn't but I might be wrong. |
I see, sorry 😅 |
You are right, reading the source tells miss-islington expects those checks to be successful too: |
No problem, TIL for me :) |
Yes, the PR will only be automerge if:
|
@andresdelfino: Status check is done, and it's a success ✅ . |
Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
@andresdelfino: Status check is done, and it's a success ✅ . |
GH-10465 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 76e8fd7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
(cherry picked from commit 76e8fd7) Co-authored-by: Andrés Delfino <adelfino@gmail.com>
No description provided.