Skip to content

bpo-35202: Remove unused imports in idle lib package #10438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2018
Merged

bpo-35202: Remove unused imports in idle lib package #10438

merged 4 commits into from
Nov 10, 2018

Conversation

srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Nov 9, 2018

@srinivasreddy srinivasreddy changed the title Remove unused imports in idlelib package bpo-35202: Remove unused imports in idlelib package Nov 9, 2018
@srinivasreddy srinivasreddy changed the title bpo-35202: Remove unused imports in idlelib package bpo-35202: Remove unused imports in Lib directory Nov 9, 2018
@terryjreedy
Copy link
Member

Please revert this PR to the original title and to only change idlelib. These changes can and should be backported to 3.7 and 3.6. If you can, add a generic blurb using the current 'lib' title. Then I will merge.

Put other changes in a separate PR for the same issue, as those likely will not be backported. If there is a blurb with this PR, another PR will not need a blurb as there should be only 1 blurb per issue.

@gvanrossum gvanrossum removed their request for review November 10, 2018 01:27
@srinivasreddy srinivasreddy changed the title bpo-35202: Remove unused imports in Lib directory bpo-35202: Remove unused imports in idle lib package Nov 10, 2018
@terryjreedy terryjreedy self-assigned this Nov 10, 2018
@terryjreedy terryjreedy merged commit 43a74ab into python:master Nov 10, 2018
@miss-islington
Copy link
Contributor

Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10447 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2018
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
@bedevere-bot
Copy link

GH-10448 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2018
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 10, 2018
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 10, 2018
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants