Skip to content

gh-58577: make function __closure__ writable #104946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-58577: make function __closure__ writable #104946

wants to merge 3 commits into from

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented May 25, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 25, 2023
Open
sobolevn
sobolevn reviewed May 28, 2023
View reviewed changes
Objects/funcobject.c
func_get_closure(PyFunctionObject *op, void *Py_UNUSED(ignored))
{
if (op->func_closure == NULL) {
Py_INCREF(Py_None);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Py_None is immortal now, but I don't know what the policy is about its use in Objects/.

I think that people still use it.

@furkanonder furkanonder added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Aug 6, 2023
@furkanonder furkanonder changed the title GH-58577: make function __closure__ writable gh-58577: make function __closure__ writable Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
awaiting review interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furkanonder @sobolevn @bedevere-bot