Skip to content

gh-92658: Fix typo in docs and tests for HV_GUID_PARENT #105267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 3, 2023

While working on python/typeshed#10247 I've noticed that HV_GUID_LOOPBACK constant is used twice, while HV_GUID_PARENT is not used at all.

Refs #92755


📚 Documentation preview 📚: https://cpython-previews--105267.org.readthedocs.build/

@sobolevn
Copy link
Member Author

sobolevn commented Jun 4, 2023

The CI failure was unrelated, but I've decided to re-run it just to be sure.

@zooba zooba merged commit 3907de1 into python:main Jun 6, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2023
…onGH-105267)

(cherry picked from commit 3907de1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-105398 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 6, 2023
zooba pushed a commit that referenced this pull request Jun 6, 2023
(cherry picked from commit 3907de1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants