Skip to content

gh-105603: Change the PyInterpreterConfig.own gil Field #105620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 10, 2023

We are changing it to be more flexible that a strict bool can be for possible future expanded used cases.

@ericsnowcurrently
Copy link
Member Author

@Yhg1s, I'd really like to make this change in 3.12 as well, given the chance that no-gil could tie into this. It's new in 3.12 so there shouldn't be much of a compatibility problem. Any objections?

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review June 13, 2023 00:37
@ericsnowcurrently ericsnowcurrently requested review from Yhg1s and removed request for brettcannon, warsaw and ncoghlan June 13, 2023 00:37
@ericsnowcurrently ericsnowcurrently merged commit b97e14a into python:main Jun 13, 2023
@miss-islington
Copy link
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105731 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2023
…gh-105620)

We are changing it to be more flexible that a strict bool can be for possible future expanded used cases.
(cherry picked from commit b97e14a)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 13, 2023
@ericsnowcurrently ericsnowcurrently deleted the rename-pyinterpreterconfig-own-gil-field branch June 13, 2023 17:09
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit b97e14a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/4755) and take a look at the build logs.
  4. Check if the failure is related to this commit (b97e14a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/464/builds/4755

Failed tests:

  • test.test_asyncio.test_subprocess

Failed subtests:

  • test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

430 tests OK.

1 test failed:
test.test_asyncio.test_subprocess

16 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_asdl_parser test_clinic
test_devpoll test_gdb test_ioctl test_kqueue test_launcher
test_perf_profiler test_startfile test_winconsoleio test_winreg
test_winsound test_wmi test_zipfile64

1 re-run test:
test.test_asyncio.test_subprocess

Total duration: 9 min 10 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.13/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.13/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.13/test/test_asyncio/test_subprocess.py", line 780, in main
    self.assertEqual(events, [
AssertionError: Lists differ: ['process_exited', ('pipe_data_received', 1, b'stdout')] != [('pipe_data_received', 1, b'stdout'), ('p[95 chars]ted']

ericsnowcurrently added a commit that referenced this pull request Jun 13, 2023
…5620) (gh-105731)

We are changing it to be more flexible that a strict bool can be for possible future expanded used cases.
(cherry picked from commit b97e14a)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants