Skip to content

gh-105751: Cleanup test_ctypes imports #105803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2023
Merged

gh-105751: Cleanup test_ctypes imports #105803

merged 2 commits into from
Jun 14, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 14, 2023 •
edited by bedevere-bot
Loading

  • Move imports at top level and sort imports.
  • Replace c_buffer() with create_string_buffer(): c_buffer is a deprecated alias.
  • PEP 8: Add empty lines for readability between imports and classes.

@vstinner
pythongh-105751: Cleanup test_ctypes imports
a2de459 
* Move imports at top level and sort imports.
* Replace c_buffer() with create_string_buffer(): c_buffer is a
  deprecated alias.
* PEP 8: Add empty lines for readability between imports and classes.
@vstinner vstinner requested a review from rhettinger as a code owner June 14, 2023 22:40
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 14, 2023
@vstinner vstinner added skip news and removed tests Tests in the Lib/test dir labels Jun 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 14, 2023
Closed
@vstinner vstinner enabled auto-merge (squash) June 14, 2023 22:48
@vstinner vstinner disabled auto-merge June 14, 2023 22:54
@vstinner vstinner enabled auto-merge (squash) June 14, 2023 22:54
@vstinner vstinner merged commit 698a0da into python:main Jun 14, 2023
@vstinner vstinner deleted the test_ctypes_cleanup branch June 27, 2023 23:16
@ambv ambv added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 31, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 698a0da7d440856a90b45964e9082b5a55387b80 3.12

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 698a0da7d440856a90b45964e9082b5a55387b80 3.11

@ambv
Copy link
Contributor

ambv commented Jul 31, 2023

oh-no

@ambv
Copy link
Contributor

ambv commented Jul 31, 2023

OK, giving up on backporting everything. It's a bummer it wasn't done though.

@ambv ambv removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @miss-islington @ambv @bedevere-bot