-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-35270: Cmd.complete: use completedefault also with cmd=None #10588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @blueyed, can you add a test and a Misc/NEWS.d
entry? You can either use blurb
or https://blurb-it.herokuapp.com/
99548a7
to
3f880da
Compare
3f880da
to
4bb8624
Compare
Added a test. |
@remilapeyre |
Otherwise it will trigger a TypeError ("must be str, not NoneType") below with: compfunc = getattr(self, 'complete_' + cmd) The doc for `parseline` states: > 'command' and 'args' may be None if the line couldn't be parsed.
4bb8624
to
704a33d
Compare
Hopefully fixed the test for Windows (skipping with missing readline), and rebased. |
Misc/NEWS.d/next/Library/2019-01-11-12-20-48.bpo-35270.Vtm5iW.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
The following commit authors need to sign the Contributor License Agreement: |
Hello, and sorry for the delay.
|
The following commit authors need to sign the Contributor License Agreement: |
Otherwise it will trigger a TypeError ("must be str, not NoneType") below with:
The doc for
parseline
state:Might need a test of course etc, but maybe one fails already..
https://bugs.python.org/issue35270
TODO: