Skip to content

gh-105844: Use devguide terminology to denote versions #105882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2023
Merged

gh-105844: Use devguide terminology to denote versions #105882

merged 2 commits into from
Jun 18, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 17, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 17, 2023
Closed
erlend-aasland
erlend-aasland commented Jun 17, 2023
View reviewed changes
@AlexWaygood
Copy link
Member

Not sure what's up with the doctest -- looks like all the individual doctests passed but Python segfaulted somewhere...?

CAM-Gerlach
CAM-Gerlach reviewed Jun 17, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM, thanks!

@erlend-aasland @CAM-Gerlach
Update Doc/install/index.rst
13d51cd 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland !

@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews!

@erlend-aasland erlend-aasland merged commit dba7217 into python:main Jun 18, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2023
@erlend-aasland @miss-islington
pythongh-105844: Use devguide terminology to denote versions (pythonG…
a7e5d76 
…H-105882)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105892 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2023
@erlend-aasland @miss-islington
pythongh-105844: Use devguide terminology to denote versions (pythonG…
118ac67 
…H-105882)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105893 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 18, 2023
@erlend-aasland erlend-aasland deleted the feature-release branch June 18, 2023 17:55
erlend-aasland added a commit that referenced this pull request Jun 18, 2023
@miss-islington @erlend-aasland
[3.11] gh-105844: Use devguide terminology to denote versions (GH-105882
043c831 
) (#105893)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 18, 2023
@miss-islington @erlend-aasland
[3.12] gh-105844: Use devguide terminology to denote versions (GH-105882
1606cbc 
) (#105892)

(cherry picked from commit dba7217)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @AlexWaygood @miss-islington @bedevere-bot @CAM-Gerlach