gh-105578: Deprecate AnyStr in the docs
#107116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Jul 23, 2023
There was a problem hiding this comment.
Thank you!
This also needs:
- A news entry
- An entry in "What's New in Python 3.13
The deprecation notice also needs to state:
- That we intend to remove it from
__all__and start emitting deprecation warnings at runtime in Python 3.16 - That we plan to remove it in Python 3.18
This comment was marked as outdated.
This comment was marked as outdated.
AlexWaygood
reviewed
Jul 23, 2023
There was a problem hiding this comment.
Nearly there! Could you also add a row to the big deprecations table at the bottom of the typing docs: https://docs.python.org/3.13/library/typing.html#deprecation-timeline-of-major-features
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
reviewed
Jul 26, 2023
There was a problem hiding this comment.
A few suggestions to add some links to https://docs.python.org/3.13/reference/compound_stmts.html#type-params
Some of these are a bit repetitive, but it's important that people see notices about upcoming removals, so it's actually a good thing if we're saying the same thing in lots of places :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
AnyStrin the docs.typing.AnyStr#105578📚 Documentation preview 📚: https://cpython-previews--107116.org.readthedocs.build/