Skip to content

gh-107082: Fix instruction size computation for ENTER_EXECUTOR #107256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jul 25, 2023

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 92b493d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2023
@vstinner
Copy link
Member

I tested manually the change on ppc64. I confirm that this change fix ./python -m test -v test_capi on big endian machine.

I built Python with ./configure --with-pydebug && make -j32: it builds C code with gcc -Og, GCC 13.1.0 on Debian Sid.

Without the fix, I am able to reproduce the issue.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The change retrieves the original opcode stored in executors by insert_executor().

Co-authored-by: Victor Stinner <vstinner@python.org>
@gvanrossum gvanrossum enabled auto-merge (squash) July 25, 2023 19:26
@gvanrossum gvanrossum merged commit 233b878 into python:main Jul 25, 2023
@gvanrossum gvanrossum deleted the fix-capi-crash branch July 25, 2023 20:06
@vstinner
Copy link
Member

Thanks for the fix.

jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_capi: test_extended_arg() failed on PPC64LE RHEL7 Refleaks 3.x
3 participants