gh-107279 Add <stddef.h> to Modules/zlibmodule.c to fix failing builds
#107280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent CI builds are failing because the `offsetof` function in `Modules/zlibmodule.c` cannot be called. For example, see https://buildbot.python.org/all/#/builders/15/builds/5217/steps/4/logs/stdio from commit fabcbe9. Here is a relevant snippet from the stdio logs for step 4 compile: ``` ../Modules/zlibmodule.c:1802:21: error: implicit declaration of function ‘offsetof’ [-Werror=implicit-function-declaration] #define COMP_OFF(x) offsetof(compobject, x) ^~~~~~~~ ../Modules/zlibmodule.c:1804:39: note: in expansion of macro ‘COMP_OFF’ {"unused_data", _Py_T_OBJECT, COMP_OFF(unused_data), Py_READONLY}, ^~~~~~~~ ../Modules/zlibmodule.c:1802:21: note: ‘offsetof’ is defined in header ‘<stddef.h>’; did you forget to ‘#include <stddef.h>’? ../Modules/zlibmodule.c:1776:1: +#include <stddef.h> ../Modules/zlibmodule.c:1802:21: #define COMP_OFF(x) offsetof(compobject, x) ^~~~~~~~ ../Modules/zlibmodule.c:1804:39: note: in expansion of macro ‘COMP_OFF’ {"unused_data", _Py_T_OBJECT, COMP_OFF(unused_data), Py_READONLY}, ^~~~~~~~ ../Modules/zlibmodule.c:1802:30: error: expected expression before ‘compobject’ #define COMP_OFF(x) offsetof(compobject, x) ^~~~~~~~~~ ```
|
I think the |
kumaraditya303
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the message in commit 733d38c for a quick overview.
Essentially, it looks like #106871 updated some internal C implementations, but missed adding
<stddef.h>to theModules/zlibmodule.cfile. I noticed this when looking at the output of the build after commit fabcbe9 was merged, and the following 2 commits (6a43cce and 2b1a81e) also failed with the same error.Interestingly, not all platforms seem to fail because of this omission. In commit 2b1a81e, for example:
This seems a odd to me, but I'm not familiar enough with the CI/build process to offer a suggestion for this discrepancy between platforms.
<stddef.h>toModules/zlibmodule.cto fix failing builds #107279