Skip to content

DO NOT MERGE: Always use -Xuops #107820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Aug 9, 2023

This exists so we can occasionally assess whether uops work everywhere, and run benchmarks. I will occasionally rebase (not merge!) to the latest main.

Failure of tests bedevere/issue-number and bedever/news, as well as Check labels / DO-NOT-MERGE / unresolved review, is expected and intentional (so I don't accidentally merge this). It is expected to be slower than main.

@gvanrossum gvanrossum force-pushed the uops-forever branch 2 times, most recently from 2771e69 to 3c00eae Compare August 21, 2023 21:35
@gvanrossum gvanrossum force-pushed the uops-forever branch 4 times, most recently from 074ed54 to 929ca3e Compare August 26, 2023 15:47
@gvanrossum gvanrossum force-pushed the uops-forever branch 3 times, most recently from 0b6e4cb to 75c669a Compare September 1, 2023 15:44
@gvanrossum gvanrossum force-pushed the uops-forever branch 3 times, most recently from ad83bdb to 825ff87 Compare September 8, 2023 03:56
@gvanrossum gvanrossum force-pushed the uops-forever branch 4 times, most recently from 27d7b8d to a01cff1 Compare October 3, 2023 23:07
@gvanrossum
Copy link
Member Author

gvanrossum commented Oct 9, 2023

There seems to be a real problem here. I can repro this on the main branch.

./python.exe -Xuops -m test test_asyncio.test_ssl

Gives lots of warnings about dangling threads, extra weakrefs, and eventually "1 test altered the execution environment (env changed)". Without -Xuops it passes silently.


Brandt found the root cause, and fixed it in GH-110593.

@gvanrossum gvanrossum closed this May 1, 2024
@gvanrossum gvanrossum deleted the uops-forever branch May 1, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant